Add entity glob matching support to history#40387
Merged
balloob merged 3 commits intohome-assistant:devfrom Sep 28, 2020
Merged
Add entity glob matching support to history#40387balloob merged 3 commits intohome-assistant:devfrom
balloob merged 3 commits intohome-assistant:devfrom
Conversation
|
Hey there @home-assistant/core, mind taking a look at this pull request as its been labeled with an integration ( |
Member
Author
|
We can remove the extra check in after this |
This was referenced Sep 21, 2020
f467ce6 to
f640e17
Compare
This was referenced Sep 22, 2020
balloob
approved these changes
Sep 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm adding this because this is the implementation used in logbook as well, and it
doesn't actual work as documented (details below). history happens to get this
for free when we fix logbook.
Proposed change
Add entity glob matching support to history
The logbook and history docs are currently wrong about the include/exclude matching as its done in sql and uses a different algorithm. The tests were not end-to-end tests and only testing
_keep_eventwhich didn't include the sql part.It actually works like this:
No includes or excludes - pass all entities
Includes, no excludes - only include specified entities
Excludes, no includes - only exclude specified entities
Both includes and excludes - include specified entities and exclude specified entities from the remaining.
Logbook is actually using both algorithms so the behavior is undefined when mixing excludes and includes so it has a broken entity globs implementation where only excludes work (in some cases) even though its documented as supporting both. #40075 fixes that, and after this PR history and logbook will both use the same method.
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: