Skip to content

Update logbook and history for entity glob matching#14589

Merged
frenck merged 4 commits into
home-assistant:nextfrom
bdraco:logger_history_globs
Sep 28, 2020
Merged

Update logbook and history for entity glob matching#14589
frenck merged 4 commits into
home-assistant:nextfrom
bdraco:logger_history_globs

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Sep 22, 2020

Proposed change

Update logbook and history for entity glob matching.

The logbook and history docs document the include/exclude method as if it was an entity filter, however include/exclude matching is done in sql and uses a different algorithm. Logbook was actually doing both so the behavior was a bit undefined.

Type of change

  • Spelling, grammar or other readability improvements (current branch).
  • Adjusted missing or incorrect information in the current documentation (current branch).
  • Added documentation for a new integration I'm adding to Home Assistant (next branch).
  • Added documentation for a new feature I'm adding to Home Assistant (next branch).
  • Removed stale or deprecated documentation.

Additional information

Checklist

  • This PR uses the correct branch, based on one of the following:
    • I made a change to the existing documentation and used the current branch.
    • I made a change that is related to an upcoming version of Home Assistant and used the next branch.
  • The documentation follows the Home Assistant documentation standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Sep 22, 2020
@klaasnicolaas klaasnicolaas added the new-feature This PR adds documentation for a new Home Assistant feature to an existing integration label Sep 22, 2020
@frenck frenck added the parent-merged The parent PR has been merged already label Sep 28, 2020
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bdraco 👍

@frenck frenck merged commit e497c77 into home-assistant:next Sep 28, 2020
@probot-home-assistant probot-home-assistant Bot removed the parent-merged The parent PR has been merged already label Sep 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants