Skip to content

Remove message and domain from logbook state_changed events#40070

Merged
bdraco merged 1 commit intohome-assistant:devfrom
bdraco:logbook_move_strings_to_frontend
Sep 30, 2020
Merged

Remove message and domain from logbook state_changed events#40070
bdraco merged 1 commit intohome-assistant:devfrom
bdraco:logbook_move_strings_to_frontend

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Sep 14, 2020

The changes have been merged into frontend 20200930.0. This can merge once frontend if bumped in core.

Breaking change

Remove message and domain from logbook state_changed events

These are now handled by the frontend as we move closer
to making the logbook localized.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bdraco bdraco added the waiting-for-upstream We're waiting for a change upstream label Sep 15, 2020
@bdraco bdraco marked this pull request as ready for review September 22, 2020 15:10
@bdraco bdraco marked this pull request as draft September 22, 2020 15:10
@bdraco bdraco force-pushed the logbook_move_strings_to_frontend branch 2 times, most recently from 603d804 to 35f3293 Compare September 24, 2020 23:26
These are now handled by the frontend as we move closer
to making the logbook localized.
@bdraco bdraco force-pushed the logbook_move_strings_to_frontend branch from 35f3293 to d7a740b Compare September 30, 2020 13:44
@bdraco bdraco marked this pull request as ready for review September 30, 2020 14:17
@bdraco
Copy link
Member Author

bdraco commented Sep 30, 2020

This can merge as soon as frontend is bumped

@bdraco
Copy link
Member Author

bdraco commented Sep 30, 2020

Verified working as expected with #40794

@bdraco bdraco merged commit 2076fc5 into home-assistant:dev Sep 30, 2020
@bdraco bdraco removed the waiting-for-upstream We're waiting for a change upstream label Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants