Add support for selecting multiple entity ids from logbook#40075
Merged
bdraco merged 13 commits intohome-assistant:devfrom Sep 22, 2020
Merged
Add support for selecting multiple entity ids from logbook#40075bdraco merged 13 commits intohome-assistant:devfrom
bdraco merged 13 commits intohome-assistant:devfrom
Conversation
49f2cd6 to
05a03cb
Compare
21 tasks
4 tasks
zsarnett
approved these changes
Sep 21, 2020
Member
Author
|
I haven't merged this yet because I've only done testing on sqlite, and I want to verify on MySQL/Maria as well. |
Member
Author
|
Testing
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports home-assistant/frontend#6976 and fixes the performance issue highlighted in #40292
I think the logbook access in the more info is the root cause of some of the reported performance issues in 0.115. The problem should just go away after this PR.
Proposed change
Add support for selecting multiple entity ids from logbook
Single/multiple entity lookups via the logbook api are at least an order of magnitude faster after this change.
Loading my garage exit door lock status before 1.32s (1324ms) after 94ms
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: