Skip to content

Add support for selecting multiple entity ids from logbook#40075

Merged
bdraco merged 13 commits intohome-assistant:devfrom
bdraco:multiple_entity_id_logbook_api
Sep 22, 2020
Merged

Add support for selecting multiple entity ids from logbook#40075
bdraco merged 13 commits intohome-assistant:devfrom
bdraco:multiple_entity_id_logbook_api

Conversation

@bdraco
Copy link
Member

@bdraco bdraco commented Sep 14, 2020

Supports home-assistant/frontend#6976 and fixes the performance issue highlighted in #40292

I think the logbook access in the more info is the root cause of some of the reported performance issues in 0.115. The problem should just go away after this PR.

Proposed change

Add support for selecting multiple entity ids from logbook

Single/multiple entity lookups via the logbook api are at least an order of magnitude faster after this change.

Loading my garage exit door lock status before 1.32s (1324ms) after 94ms

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bdraco bdraco force-pushed the multiple_entity_id_logbook_api branch from 49f2cd6 to 05a03cb Compare September 20, 2020 19:05
@bdraco
Copy link
Member Author

bdraco commented Sep 22, 2020

I haven't merged this yet because I've only done testing on sqlite, and I want to verify on MySQL/Maria as well.

@bdraco
Copy link
Member Author

bdraco commented Sep 22, 2020

Testing

  • sqlite
  • MySQL
  • MariaDB (should be the same)

@bdraco bdraco merged commit 7029345 into home-assistant:dev Sep 22, 2020
@bdraco bdraco deleted the multiple_entity_id_logbook_api branch September 22, 2020 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Higher CPU continues in 0.118

3 participants