Clean up device registry if entity registry updates#35106
Merged
Conversation
MartinHjelmare
approved these changes
May 3, 2020
Contributor
|
Would this cause issues for integrations with deferred entity loading? E.g. zha could take a while to quert all devices, so it doesn't delay ha start, but continue loading in the background. I.e. zha entities might not be available on ha startup |
Member
Author
|
@Adminiuga cleanup is based on the entity registry. The ZHA entries are available there even if ZHA is not booted. This really is the use case if people are manually removing entities via the frontend etc. |
This was referenced May 6, 2020
bdraco
pushed a commit
that referenced
this pull request
May 11, 2020
* ISY994 Add Services ISY994 Add support for climate platform * Remove device registry cleanup Remove device registry cleanup from service in favor of #35106 * ISY994 Update Services Definitions Rename entry to config_entry_id * Grammar corrections Fix Typo * Add await and lower logging per review. * Rename to entries and remove unused device_id refs * Fix tuple typo * Fix Typo in strings * Fix typo in strings
rhadamantys
pushed a commit
to rhadamantys/home-assistant
that referenced
this pull request
May 11, 2020
* ISY994 Add Services ISY994 Add support for climate platform * Remove device registry cleanup Remove device registry cleanup from service in favor of home-assistant#35106 * ISY994 Update Services Definitions Rename entry to config_entry_id * Grammar corrections Fix Typo * Add await and lower logging per review. * Rename to entries and remove unused device_id refs * Fix tuple typo * Fix Typo in strings * Fix typo in strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
After startup or when entity registry entries are removed or their device ID is updated, schedule a cleanup of the device registry.
Devices will be removed if:
That last one is actually a bug, because config entry removal is supposed to do this but somehow it can happen that devices end up referring to a non-existing config entry. I have been unable to track it down but it ends up breaking random things like device automations.
Note: The logic in this PR to remove devices without config entries was modified by #35977
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: