Add config flow for Tuya

[ollo69]

Breaking change

Adding config flow, the Tuya configuration from configuration.yaml is used only the first time during import phase. In case of credential change it is required to reconfigure the integration, changing credential in configuration.yaml is not enought.
Al other features are maintened.

Proposed change

This PR is to add config flow to Tuya and so simplify the configuration process of the integration and benefit of all the additional information provided by the devices registry.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

Configuration.yaml entries are not changed and are explained on integration manual page

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request: Add config flow and device registry to Tuya integration home-assistant.io#13389

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

[joogps]

Did you format your code with black?

[ollo69]

Did you format your code with black?

Yes I did, seem few exception in my last commit. Fixing now...

[bdraco]

@ollo69

Thank you for your contribution thus far! 🎖 Since this is a significant contribution, we would appreciate you'd added yourself to the list of code owners for this integration. ❤️

Please, add your GitHub username to the manifest.json of this integration.

For more information about "code owners", see: Architecture Decision Record 0008: Code owners.

[ollo69]

Do you think I should set to deprecated the configuration file option?

CONFIG_SCHEMA = vol.Schema(
    vol.All(
        cv.deprecated(DOMAIN),
        {
            DOMAIN: vol.Schema(
                {
                    vol.Required(CONF_PASSWORD): cv.string,
                    vol.Required(CONF_USERNAME): cv.string,
                    vol.Required(CONF_COUNTRYCODE): cv.string,
                    vol.Optional(CONF_PLATFORM, default="tuya"): cv.string,
                }
            )
        },
    ),
    extra=vol.ALLOW_EXTRA,
)

[bdraco]

cv.deprecated

Yes, there doesn't seem anything that is yaml only here.

[bdraco]

Looks good. I did some basic testing with this. I don't have a tuya account so I could only test the fail paths.

[bdraco]

Sorry I missed it before, but there is one more change needed in the test to use hass.config_entries.flow.async_init

If you need an example of how this works, check harmony

[ollo69]

Sorry I missed it before, but there is one more change needed in the test to use hass.config_entries.flow.async_init

If you need an example of how this works, check harmony

Not so expert here. I changed using also FritzBox implementation as example.
Now is using hass.config_entries.flow.async_init, let me know if is ok.

[bdraco]

Sorry I missed it before, but there is one more change needed in the test to use hass.config_entries.flow.async_init
If you need an example of how this works, check harmony

Not so expert here. I changed using also FritzBox implementation as example.
Now is using hass.config_entries.flow.async_init, let me know if is ok.

For the ones that will create a config entry we should mock out async_setup and async_setup_entry to make sure the integration isn't actually setup and won't do I/O in the future from the test which can cause flapping test failures.

patch(
        "homeassistant.components.tuya.async_setup", return_value=True
    ) as mock_setup, patch(
        "homeassistant.components.tuya.async_setup_entry", return_value=True,
    ) as mock_setup_entry:

Then we can assert that the setup was called.

    await hass.async_block_till_done()
    assert len(mock_setup.mock_calls) == 1
    assert len(mock_setup_entry.mock_calls) == 1

[bdraco]

@ollo69 did you get a chance to retest all your devices to make sure everything is still working as expected?

[ollo69]

I always check locally that everything is OK before commiting, so I can confirm that last change work properly.
Of course I can test only my devices, Tuya have tons...
I suppose that this will be tested in beta release and a issue will be open if something do not work,

[bdraco]

Looks like we just need a docs PR, and this is good to merge

[ollo69]

Looks like we just need a docs PR, and this is good to merge

I'll open doc PR shortly

[MartinHjelmare]

Please address the comments in a new PR. Thanks!

[ollo69]

New PR #35497 opened.