Fix device_registry cleanup behavior#35977
Merged
MartinHjelmare merged 3 commits intohome-assistant:devfrom May 23, 2020
Merged
Fix device_registry cleanup behavior#35977MartinHjelmare merged 3 commits intohome-assistant:devfrom
MartinHjelmare merged 3 commits intohome-assistant:devfrom
Conversation
3 tasks
5de6098 to
448b217
Compare
448b217 to
0927533
Compare
frenck
pushed a commit
that referenced
this pull request
May 24, 2020
* Fix: Only decives which are not referenced by an entity or a config_entry are removed * Adapted test for async_cleanup * Changed variable names
Merged
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed change
PR #35106 introduced the
async_cleanupcallback indevice_registry.pywhich ensures that all devices without reference to an entity or reference to a config_entry are removed from the device registry.Other than stated in the PR, all devices are removed which are not referenced by an entity.
Currently there is no check if instead they are referenced by a config_entry. The latter occurs for example for hubs or hardware devices containing many sensors. Those devices are usually not directly linked to an entity but managed by a config_entry.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale: