Skip to content

Change hive hotwater to hot_water + bug fix#27038

Merged
MartinHjelmare merged 2 commits into
home-assistant:devfrom
Rendili:Hot_water-Fix
Sep 29, 2019
Merged

Change hive hotwater to hot_water + bug fix#27038
MartinHjelmare merged 2 commits into
home-assistant:devfrom
Rendili:Hot_water-Fix

Conversation

@KJonline
Copy link
Copy Markdown
Contributor

@KJonline KJonline commented Sep 28, 2019

Description:

Fix Hotwater to hot_water + bug fix

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10474

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]

If the code communicates with devices, web services, or third-party tools:

  • [The manifest file][manifest-docs] has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.

@KJonline
Copy link
Copy Markdown
Contributor Author

Hi @MartinHjelmare, I have closed the other PR and created this pone from a new branch. I had trouble rebasing the other branch so o have also created a new PR for the documentation and closed the other.

@KJonline
Copy link
Copy Markdown
Contributor Author

Hi @MartinHjelmare, its probably worth noting the change to the library version is a bug fix ontop of the TRV support being added in PR #27033. if these two PR's cannot be released in the same Home Assistant release. Please let me know as I will have to create a new version of the library and update it as part of this PR.

@MartinHjelmare
Copy link
Copy Markdown
Member

Can we merge?

@KJonline
Copy link
Copy Markdown
Contributor Author

hi @MartinHjelmare, if you are happy to also merge the TRV support Pr #27033 then we are good to go with this. If you think more work is required in the TRV support, then we may need to create a new version of pyhiveapi. I did a bug fix in this pr which was a change to the library, I applied that fix on top of the trv support code. If the trv support code doesn’t make this release then I need to create a new version of pyhiveapi with bug fix on top of the current production code.

@KJonline
Copy link
Copy Markdown
Contributor Author

Hi @MartinHjelmare, I needed to make a change to the pyhiveapi library to support the TRV support pr. I also took the opportunity to separate the dependancy between this PR and the TRV support pr.

This PR can now be merged and doesn't depend on the TRV support change.

@MartinHjelmare MartinHjelmare changed the title Updated hotwater to hot_water + bug fix Change hotwater to hot_water + bug fix Sep 29, 2019
@MartinHjelmare MartinHjelmare changed the title Change hotwater to hot_water + bug fix Change hive hotwater to hot_water + bug fix Sep 29, 2019
@MartinHjelmare MartinHjelmare merged commit 2ebc190 into home-assistant:dev Sep 29, 2019
@lock lock Bot locked and limited conversation to collaborators Sep 30, 2019
@KJonline KJonline deleted the Hot_water-Fix branch October 4, 2019 18:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants