Change hive hotwater to hot_water + bug fix#27038
Conversation
|
Hi @MartinHjelmare, I have closed the other PR and created this pone from a new branch. I had trouble rebasing the other branch so o have also created a new PR for the documentation and closed the other. |
|
Hi @MartinHjelmare, its probably worth noting the change to the library version is a bug fix ontop of the TRV support being added in PR #27033. if these two PR's cannot be released in the same Home Assistant release. Please let me know as I will have to create a new version of the library and update it as part of this PR. |
|
Can we merge? |
|
hi @MartinHjelmare, if you are happy to also merge the TRV support Pr #27033 then we are good to go with this. If you think more work is required in the TRV support, then we may need to create a new version of pyhiveapi. I did a bug fix in this pr which was a change to the library, I applied that fix on top of the trv support code. If the trv support code doesn’t make this release then I need to create a new version of pyhiveapi with bug fix on top of the current production code. |
|
Hi @MartinHjelmare, I needed to make a change to the pyhiveapi library to support the TRV support pr. I also took the opportunity to separate the dependancy between this PR and the TRV support pr. This PR can now be merged and doesn't depend on the TRV support change. |
Description:
Fix Hotwater to hot_water + bug fix
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10474
Checklist:
tox. Your PR cannot be merged unless tests passIf the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all.