Add hive trv support by MagicalTrev89 · Pull Request #27033 · home-assistant/core

MagicalTrev89 · 2019-09-28T11:36:22Z

Description:

This PR brings TRV support to the Hive Plugin

Docs PR:

home-assistant/home-assistant.io#10607

Related issue (if applicable):
fixes Rendili/hive-for-home-assistant#3

Checklist:

The code change is tested and works locally.
Local tests pass with tox. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist

homeassistant · 2019-09-28T11:36:24Z

Hi @MagicalTrev89,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

MartinHjelmare · 2019-09-28T12:26:49Z

Please solve the merge conflicts.

KJonline

Hi @MagicalTrev89, I have fixed the pylint issues from the merge conflict. as I cannot checkout your branch, I cannot fix the formatting issue that the latest commit is failing on. Please could you take a look at this.

MagicalTrev89 · 2019-09-28T19:53:15Z

Hi @KJonline, New to this... please could you point me to what its failing on ?

MagicalTrev89 · 2019-09-28T20:33:27Z

Hi @KJonline, worked it out ... i've updated the formatting issues, those tests that failed have passed now

KJonline · 2019-09-29T09:09:07Z

@MagicalTrev89, please can you also include the manifest.json file updating the pyhiveapi library version to 0.2.19.3 and running the below before committing it in.

python3 -m script.gen_requirements_all

MartinHjelmare · 2019-09-29T12:34:58Z

Please solve the merge conflict.

MagicalTrev89 · 2019-09-29T12:39:24Z

@KJonline can you sort out the conflict please?

KJonline · 2019-09-29T13:35:12Z

@KJonline can you sort out the conflict please?

That’s sorted now

MartinHjelmare · 2019-09-29T14:34:02Z

Please run black from the project root.

black --fast homeassistant

…ssistant into TRV-Support black

MagicalTrev89 · 2019-09-30T08:07:25Z

Hi @KJonline Are you sure about pyhiveapi version: 0.2.19.3, build is failing saying it doesn't exist, are you in the process of releasing that version ?

KJonline · 2019-09-30T11:04:11Z

Hi @KJonline Are you sure about pyhiveapi version: 0.2.19.3, build is failing saying it doesn't exist, are you in the process of releasing that version ?

Apologies I seem to have created the version but not uploaded it to PyPi. I’ll upload it this evening.

KJonline · 2019-09-30T18:53:51Z

Hi @MagicalTrev89, I have uploaded ver 0.2.19.3 of pyhiveapi, it should now be available to download.

MagicalTrev89 · 2019-10-01T09:27:57Z

@MartinHjelmare @KJonline is there any way to restart the build checks without having to do another commit ?

MartinHjelmare · 2019-10-01T09:43:27Z

You can close and reopen the PR.

MartinHjelmare

Good!

MartinHjelmare · 2019-10-01T15:32:26Z

We should probably update the docs and mention TRV here:
https://www.home-assistant.io/components/hive/#climate

MartinHjelmare · 2019-10-01T15:32:45Z

Can be merged when a docs PR is linked in the PR description.

KJonline · 2019-10-04T18:59:41Z

Hi @MagicalTrev89, I have updated the docs in PR home-assistant/home-assistant.io#10607, Please can you edit this PR linking them together in the description of this PR

MagicalTrev89 · 2019-10-05T10:28:30Z

@KJonline looks like its already done! 👍 @MartinHjelmare can you approve now ?

MagicalTrev89 and others added 5 commits August 9, 2019 14:44

TRV-Support

dd6d40f

pyhive import update

4068e86

Moved HVAC to new line

f1464cf

Merge branch 'TRV-Support' into TRV-Support

285b256

updated pyhiveapi version

138dd6e

homeassistant added the cla-needed label Sep 28, 2019

probot-home-assistant Bot added the integration: hive label Sep 28, 2019

homeassistant added cla-signed and removed cla-needed labels Sep 28, 2019

Khole added 5 commits September 28, 2019 17:31

Merge branch 'dev' into TRV-Support

8f03051

Update for pylint errors

ee195b1

Fix Pylint Errors

0cd449f

Fixed Pylint 2

0c3aac5

removed whitespace

b99ac72

KJonline mentioned this pull request Sep 28, 2019

Change hive hotwater to hot_water + bug fix #27038

Merged

6 tasks

KJonline reviewed Sep 28, 2019

View reviewed changes

Black

bec70b0

MartinHjelmare requested changes Sep 29, 2019

View reviewed changes

Comment thread homeassistant/components/hive/__init__.py

Comment thread homeassistant/components/hive/climate.py Outdated

Comment thread homeassistant/components/hive/climate.py

Comment thread homeassistant/components/hive/climate.py Outdated

MartinHjelmare changed the title ~~Trv support~~ Add hive trv support Sep 29, 2019

KJonline suggested changes Sep 29, 2019

View reviewed changes

Comment thread homeassistant/components/hive/climate.py Outdated

Comment thread homeassistant/components/hive/climate.py

Updates following review

9f573c6

MartinHjelmare reviewed Sep 29, 2019

View reviewed changes

Comment thread homeassistant/components/hive/climate.py Outdated

updated phyhive to 0.2.19.3

c08511e

Corrected logic on TRV name

500df5e

MagicalTrev89 and others added 2 commits September 29, 2019 13:43

updated requirements as requested

3d18790

Merge branch 'dev' into TRV-Support

04db88a

MagicalTrev89 added 2 commits September 29, 2019 19:14

Black run

c6c12d2

Merge branch 'TRV-Support' of https://github.com/MagicalTrev89/home-a…

63c7e97

…ssistant into TRV-Support black

MagicalTrev89 closed this Oct 1, 2019

MagicalTrev89 reopened this Oct 1, 2019

MartinHjelmare approved these changes Oct 1, 2019

View reviewed changes

MartinHjelmare added the docs-missing label Oct 1, 2019

KJonline mentioned this pull request Oct 4, 2019

Add trv support home-assistant/home-assistant.io#10607

Merged

2 tasks

frenck removed the docs-missing label Oct 4, 2019

KJonline approved these changes Oct 5, 2019

View reviewed changes

MartinHjelmare merged commit a907345 into home-assistant:dev Oct 5, 2019

lock Bot locked and limited conversation to collaborators Oct 6, 2019

Uh oh!

Conversation

MagicalTrev89 commented Sep 28, 2019 • edited by MartinHjelmare Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description:

Docs PR:

Checklist:

Uh oh!

homeassistant commented Sep 28, 2019

Uh oh!

MartinHjelmare commented Sep 28, 2019

Uh oh!

KJonline left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MagicalTrev89 commented Sep 28, 2019

Uh oh!

MagicalTrev89 commented Sep 28, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

KJonline commented Sep 29, 2019

Uh oh!

Uh oh!

MartinHjelmare commented Sep 29, 2019

Uh oh!

MagicalTrev89 commented Sep 29, 2019

Uh oh!

KJonline commented Sep 29, 2019

Uh oh!

MartinHjelmare commented Sep 29, 2019

Uh oh!

MagicalTrev89 commented Sep 30, 2019

Uh oh!

KJonline commented Sep 30, 2019

Uh oh!

KJonline commented Sep 30, 2019

Uh oh!

MagicalTrev89 commented Oct 1, 2019

Uh oh!

MartinHjelmare commented Oct 1, 2019

Uh oh!

MartinHjelmare left a comment

Choose a reason for hiding this comment

Uh oh!

MartinHjelmare commented Oct 1, 2019

Uh oh!

MartinHjelmare commented Oct 1, 2019

Uh oh!

KJonline commented Oct 4, 2019

Uh oh!

MagicalTrev89 commented Oct 5, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

MagicalTrev89 commented Sep 28, 2019 •

edited by MartinHjelmare

Loading

KJonline left a comment •

edited

Loading