Skip to content

Change hive hotwater to hot_water + bug fix #27038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MartinHjelmare merged 2 commits into from
Sep 29, 2019
Merged

Change hive hotwater to hot_water + bug fix #27038

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a0b833
Updated hotwater to hot_water + bug fix
Sep 28, 2019
dba109c
Updated version seperating dependancy
Sep 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions homeassistant/components/hive/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
DOMAIN = "hive"
DATA_HIVE = "data_hive"
SERVICES = ["Heating", "HotWater"]
SERVICE_BOOST_HOTWATER = "boost_hotwater"
SERVICE_BOOST_HOT_WATER = "boost_hot_water"
SERVICE_BOOST_HEATING = "boost_heating"
ATTR_TIME_PERIOD = "time_period"
ATTR_MODE = "on_off"
Expand Down Expand Up @@ -59,7 +59,7 @@
}
)

BOOST_HOTWATER_SCHEMA = vol.Schema(
BOOST_HOT_WATER_SCHEMA = vol.Schema(
{
vol.Required(ATTR_ENTITY_ID): cv.entity_id,
vol.Optional(ATTR_TIME_PERIOD, default="00:30:00"): vol.All(
Expand Down Expand Up @@ -100,7 +100,7 @@ def heating_boost(service):

session.heating.turn_boost_on(node_id, minutes, temperature)

def hotwater_boost(service):
def hot_water_boost(service):
"""Handle the service call."""
node_id = HiveSession.entity_lookup.get(service.data[ATTR_ENTITY_ID])
if not node_id:
Expand Down Expand Up @@ -151,9 +151,9 @@ def hotwater_boost(service):
if ha_type == "water_heater":
hass.services.register(
DOMAIN,
SERVICE_BOOST_HEATING,
hotwater_boost,
schema=BOOST_HOTWATER_SCHEMA,
SERVICE_BOOST_HOT_WATER,
hot_water_boost,
schema=BOOST_HOT_WATER_SCHEMA,
)

return True
Expand Down
2 changes: 1 addition & 1 deletion homeassistant/components/hive/manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"name": "Hive",
"documentation": "https://www.home-assistant.io/components/hive",
"requirements": [
"pyhiveapi==0.2.19"
"pyhiveapi==0.2.19.2"
],
"dependencies": [],
"codeowners": [
Expand Down
2 changes: 1 addition & 1 deletion homeassistant/components/hive/services.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ boost_heating:
description: Set the target temperature for the boost period.,
example: "20.5",
}
boost_hotwater:
boost_hot_water:
description:
"Set the boost mode ON or OFF defining the period of time for the boost."
fields:
Expand Down
2 changes: 1 addition & 1 deletion requirements_all.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1223,7 +1223,7 @@ pyheos==0.6.0
pyhik==0.2.3

# homeassistant.components.hive
pyhiveapi==0.2.19
pyhiveapi==0.2.19.2

# homeassistant.components.homematic
pyhomematic==0.1.60
Expand Down