Skip to content

Add manual step to Plex config flow#26773

Merged
MartinHjelmare merged 6 commits into
home-assistant:devfrom
jjlawren:plex_manual_flow
Sep 22, 2019
Merged

Add manual step to Plex config flow#26773
MartinHjelmare merged 6 commits into
home-assistant:devfrom
jjlawren:plex_manual_flow

Conversation

@jjlawren
Copy link
Copy Markdown
Contributor

@jjlawren jjlawren commented Sep 20, 2019

Description:

Allows users to manually configure a Plex server via the config flow. Followup to #26548.

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#10412

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

Comment thread homeassistant/components/plex/config_flow.py Outdated
Comment thread homeassistant/components/plex/config_flow.py
Comment thread homeassistant/components/plex/config_flow.py Outdated
Comment thread homeassistant/components/plex/config_flow.py Outdated
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good!

@MartinHjelmare
Copy link
Copy Markdown
Member

Can be merged when a docs PR is linked in the PR description.

@MartinHjelmare MartinHjelmare merged commit 5914475 into home-assistant:dev Sep 22, 2019
@lock lock Bot locked and limited conversation to collaborators Sep 23, 2019
@jjlawren jjlawren deleted the plex_manual_flow branch September 24, 2019 01:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants