Skip to content

Plex common config#10328

Merged
frenck merged 10 commits into
home-assistant:nextfrom
jjlawren:plex_common_config
Sep 10, 2019
Merged

Plex common config#10328
frenck merged 10 commits into
home-assistant:nextfrom
jjlawren:plex_common_config

Conversation

@jjlawren
Copy link
Copy Markdown
Contributor

@jjlawren jjlawren commented Sep 9, 2019

Description:
Moves configuration from platforms to component. Updates descriptions to put common information to top, outside of media_player section.

Dependent on #10297 and #10303

Pull request in home-assistant (if applicable): home-assistant/core#26488

Checklist:

  • Branch: next is for changes and new documentation that will go public with the next Home Assistant release. Fixes, changes and adjustments for the current release should be created against current.
  • The documentation follows the standards.

@probot-home-assistant probot-home-assistant Bot added has-parent This PR has a parent PR in another repo next This PR goes into the next branch labels Sep 9, 2019
@klaasnicolaas klaasnicolaas added the ready-for-review This PR needs to be reviewed label Sep 9, 2019
@frenck frenck added the parent-merged The parent PR has been merged already label Sep 10, 2019
Comment thread source/_components/plex.markdown Outdated
Comment thread source/_components/plex.markdown Outdated
Comment thread source/_components/plex.markdown Outdated
jjlawren and others added 2 commits September 10, 2019 16:01
Co-Authored-By: Franck Nijhof <frenck@frenck.nl>
Copy link
Copy Markdown
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now! 👍

@frenck frenck merged commit dab942c into home-assistant:next Sep 10, 2019
@probot-home-assistant probot-home-assistant Bot removed ready-for-review This PR needs to be reviewed parent-merged The parent PR has been merged already labels Sep 10, 2019
@bbrendon bbrendon mentioned this pull request Sep 23, 2019
2 tasks
@jjlawren jjlawren deleted the plex_common_config branch May 8, 2020 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

has-parent This PR has a parent PR in another repo next This PR goes into the next branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants