Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enphase envoy individual inverter production #24445

Merged
merged 17 commits into from
Jul 8, 2019
Merged

Enphase envoy individual inverter production #24445

merged 17 commits into from
Jul 8, 2019

Conversation

jesserizzo
Copy link
Contributor

@jesserizzo jesserizzo commented Jun 9, 2019

Description: Enphase Envoy component, get production values from individual inverters

Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#9600

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly. Update and include derived files by running python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

homeassistant/components/enphase_envoy/sensor.py Outdated Show resolved Hide resolved
@homeassistant
Copy link
Contributor

This pull request has been mentioned on Home Assistant Community. There might be relevant details there:

https://community.home-assistant.io/t/trouble-with-enphase-envoy/67359/37

@jesserizzo
Copy link
Contributor Author

@MartinHjelmare Here's my first crack at breaking those attributes out into their own sensors.

@home-assistant home-assistant deleted a comment Jun 22, 2019
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare
Copy link
Member

There are some merge conflicts.

@jesserizzo
Copy link
Contributor Author

Derp, fixed conflicts. @MartinHjelmare @andrewsayre

@jesserizzo
Copy link
Contributor Author

@andrewsayre I refactored enough that I don't think any of your requested changes still apply.

@jesserizzo
Copy link
Contributor Author

@MartinHjelmare Seems like andrewsayre has ghosted me, can you merge this without his approval?

@andrewsayre
Copy link
Member

@MartinHjelmare Seems like andrewsayre has ghosted me, can you merge this without his approval?

I was not aware you were waiting on anything from me. Martin already approved the PR. :)

@andrewsayre andrewsayre merged commit f90fe7e into home-assistant:dev Jul 8, 2019
KJonline pushed a commit to Rendili/home-assistant that referenced this pull request Jul 8, 2019
… into hive_water_heater

* 'hive_water_heater' of github.com:Rendili/home-assistant: (21 commits)
  Sensibo, add HVAC_MODE_OFF (home-assistant#25016)
  Add support for arcam fmj receivers (home-assistant#24621)
  Enphase envoy individual inverter production (home-assistant#24445)
  Implement Twilio SMS notify MediaUrl support (home-assistant#24971)
  Climate 1.0 (home-assistant#23899)
  Correct socket use in cert_expiry platform (home-assistant#25011)
  Added missing yeelight models mapping (home-assistant#24963)
  Install requirements for integrations in packages before importing them. (home-assistant#25005)
  Upgrade insteonplm to 0.16.0 and add INSTEON scene triggering (home-assistant#24765)
  Upgrade hdate==0.8.8 (home-assistant#25008)
  upgrade switchmate to latest lib (home-assistant#25006)
  Test dependency updates (home-assistant#25004)
  Add support for aurora ABB Powerone solar photovoltaic inverter (home-assistant#24809)
  Sleepiq single sleeper crash (home-assistant#24941)
  Changes as per code review of home-assistant#24646 (home-assistant#24917)
  Upgrade mypy to 0.711, drop no longer needed workarounds (home-assistant#24998)
  Adds Stale Probot for issues (home-assistant#24985)
  Adds Lock Threads Probot (home-assistant#24984)
  Switched from tuyapy to tuyaha as 1st one is not maintained (home-assistant#24821)
  Fix errors if rest source becomes unavailable (home-assistant#24986)
  ...

# Conflicts:
#	homeassistant/components/hive/__init__.py
#	homeassistant/components/hive/climate.py
@balloob balloob mentioned this pull request Jul 17, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
* bump envoy_reader version to 0.4

* bump dependency envoy_reader to 0.4

* Enphase envoy get individual inverter production

* Add period in function description

* Fix dumb typo

* Define _attributes in __init__

* Better error messages, make update async

* Fix format error

* Fix pylint errors

* set unknown state to None

* Bump envoy_reader version to 0.8

* Change attributes to separate sensors

* Fix dumb thing

* Improve platform_setup for inverters

* Remove unneeded self._attributes, refactor platform setup

* Refactor platform setup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants