-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sleepiq single sleeper crash #24941
Merged
pvizeli
merged 10 commits into
home-assistant:dev
from
qypea:sleepiq-single-sleeper-crash
Jul 7, 2019
Merged
Sleepiq single sleeper crash #24941
pvizeli
merged 10 commits into
home-assistant:dev
from
qypea:sleepiq-single-sleeper-crash
Jul 7, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes crash when working with a single sleeper.
These happen if no sleeper is defined for a side of the bed. Don't create sensors for null sides; they'll crash every time we try to use them.
homeassistant
added
integration: sleepiq
small-pr
PRs with less than 30 lines.
cla-needed
cla-signed
and removed
cla-needed
labels
Jul 4, 2019
Sleepyq 0.7 throws on empty strings, so we have to specify them.
pvizeli
requested changes
Jul 6, 2019
pvizeli
approved these changes
Jul 7, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): fixes #24795
Pull request with documentation for home-assistant.io (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest
.requirements_all.txt
by runningpython3 -m script.gen_requirements_all
..coveragerc
.If the code does not interact with devices: