Adds Lock Threads Probot #24984
Merged
Adds Lock Threads Probot #24984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balloob
reviewed
Jul 6, 2019
| # Configuration for Lock Threads - https://github.com/dessant/lock-threads | ||
|
|
||
| # Number of days of inactivity before a closed issue or pull request is locked | ||
| daysUntilLock: 1 |
There was a problem hiding this comment.
I wonder if we should set it to 7 days? Immediate feedback might be useful, and 7 days is the time the beta lasts, which is what usually attracts bad comments (because we do a release that links all the posts)
There was a problem hiding this comment.
I started writing a comment on which I agreed and suggest to prolong it to 21 in that case to cover the whole release period. Remove it, started over again.
I think it should be issues, not comments on PR. Issues can be milestoned and marked as a beta issue. Those are trackable. Whatever happens on a closed PR is not trackable in any way.
I'm happy to adjust, but please consider the above.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We are dealing with a lot of people that are commenting on merged PR's (sometimes really old ones).
They should have created an issue.
This PR adds the Lock Threads Probot, which is able to Lock merged PR's and closed issues, and thus limiting further comments to just collaborators.
This requires this app to be installed: https://github.com/apps/lock
⚠️ Install this app on specific this repository but not on the organization!
I've configured merged PR's to be locked in 1 day and issues 30 days after closing.
There is no message left, and no labels set to prevent notifications being triggered.
PS: Issue locking is turned off for the time being, since I feel PR's are the culprit
Related issue (if applicable): n/a
Pull request with documentation for home-assistant.io (if applicable): n/a
Example entry for
configuration.yaml(if applicable): n/aChecklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
python3 -m script.hassfest.requirements_all.txtby runningpython3 -m script.gen_requirements_all..coveragerc.If the code does not interact with devices: