-
-
Notifications
You must be signed in to change notification settings - Fork 32.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing yeelight models mapping #24963
Conversation
Hey there @rytilahti, @zewelor, mind taking a look at this pull request as its been labeled with a integration ( This is a automatic comment generated by codeowners-mention to help ensure issues and pull requests are seen by the right people. |
lamp1 is whitetemp for sure, not mono ? Its possible to set_mode to nightlight on it ? |
It is not possible to
PS On the other hand |
Sorry does mode moonlight works on it. For effects I've recently whitelisted effets, that are supported on non color light, does they work on this lamp ? |
For me it looks good. |
can you update the issue number is fixes, as it points to a different one (missing 2 at the end by looks of it) |
By whitelisted effects you mean just "Slow temp"? No, it does nothing or I noticed nothing. @aidbish thanks for spotting, somehow |
Its not updated because it reads model specs from https://gitlab.com/stavros/python-yeelight/blob/master/yeelight/main.py#L37 . It would require to add model also there and update python-yeelight. |
So I'm leaving this to you. I'm bringing |
So, if I'm reading it correctly, this fixes a known issue without breaking anything, so I think this should get merged. Not updating the nightlight state is another issue, which can be solved in a separate PR. Thanks for the PR @cadavre and thanks @zewelor for your insight on how to fix that another issue! |
Breaking Change:
No breaking changes.
Description:
Adds support for missing
yeelight
models.Related issue (if applicable):
Fixes #24962
Checklist:
tox
.