Support OpenWRT 18.06 in luci device tracker#21236
Merged
Merged
Conversation
ghost
added
the
8 tasks
MartinHjelmare
requested changes
Feb 20, 2019
Member
MartinHjelmare
left a comment
MartinHjelmare
left a comment
There was a problem hiding this comment.
Just a couple of things left to fix.
Contributor
Author
|
Thanks @MartinHjelmare I appreciate the time spent on this review. |
thibmaek
added a commit
to thibmaek/home-assistant
that referenced
this pull request
Feb 21, 2019
* upstream/dev: (948 commits) Prevent partial custom component overlays (home-assistant#21070) Alarm trigger support for Point (home-assistant#21207) Upgrade opensensemap-api to 0.1.4 (home-assistant#21240) Remove constraint from regex (home-assistant#21239) Updated frontend to 20190220.0 Support OpenWRT 18.06 in luci device tracker (home-assistant#21236) Bump zigpy (home-assistant#21203) Fix bug in ZHA and tweak non sensor channel logic (home-assistant#21234) Don't dispatch to components when there are no channels for ZHA sensors (home-assistant#21223) Add zone and reps for Xiaomi vacuum (home-assistant#19777) Fix an Ambient PWS exception when location info is missing (home-assistant#21220) Add self to integration sensor and utility_meter (home-assistant#21226) Prevent invalid context from crashing (home-assistant#21231) Update pyhomematic to 0.1.56 (home-assistant#21227) Fix the build (home-assistant#21229) Updated frontend to 20190219.0 Add yeelight flow action support (home-assistant#21195) Refactor ZHA listeners into channels (home-assistant#21196) Fix Homematic IP Cloud configuration (home-assistant#21202) Push pyads to 3.0.7 (home-assistant#21216) ...
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Updating luci rpc device tracker to use new APIs in OpenWRT 18.06.
As recommended in the old PR #15792 , I have moved RPC logic into a pip module called openwrt-luci-rpc
This is a retake of the PR #21233 which got messed up with the wrong CLA email in one commit. (apologies about that!)
Related issue (if applicable): fixes #8508
Checklist:
tox.If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: