Skip to content

Prevent invalid context from crashing#21231

Merged
pvizeli merged 2 commits into
devfrom
prevent-invalid-context-crashing
Feb 20, 2019
Merged

Prevent invalid context from crashing#21231
pvizeli merged 2 commits into
devfrom
prevent-invalid-context-crashing

Conversation

@balloob
Copy link
Copy Markdown
Member

@balloob balloob commented Feb 19, 2019

Description:

Prevent invalid context data in restore data from crashing the restore state code.

I had some stored states from my PR #21028 which started breaking when I checked out dev again. This code solves it.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from a team as a code owner February 19, 2019 23:26
@ghost ghost assigned balloob Feb 19, 2019
@ghost ghost added the in progress label Feb 19, 2019
Comment thread tests/test_core.py Outdated
@pvizeli pvizeli merged commit cf3a8b6 into dev Feb 20, 2019
@ghost ghost removed the in progress label Feb 20, 2019
@delete-merged-branch delete-merged-branch Bot deleted the prevent-invalid-context-crashing branch February 20, 2019 07:03
@balloob balloob added this to the 0.88.0 milestone Feb 20, 2019
balloob added a commit that referenced this pull request Feb 20, 2019
* Prevent invalid context from crashing

* Lint
@balloob balloob mentioned this pull request Feb 20, 2019
thibmaek added a commit to thibmaek/home-assistant that referenced this pull request Feb 21, 2019
* upstream/dev: (948 commits)
  Prevent partial custom component overlays (home-assistant#21070)
  Alarm trigger support for Point (home-assistant#21207)
  Upgrade opensensemap-api to 0.1.4 (home-assistant#21240)
  Remove constraint from regex (home-assistant#21239)
  Updated frontend to 20190220.0
  Support OpenWRT 18.06 in luci device tracker (home-assistant#21236)
  Bump zigpy (home-assistant#21203)
  Fix bug in ZHA and tweak non sensor channel logic (home-assistant#21234)
  Don't dispatch to components when there are no channels for ZHA sensors (home-assistant#21223)
  Add zone and reps for Xiaomi vacuum (home-assistant#19777)
  Fix an Ambient PWS exception when location info is missing (home-assistant#21220)
  Add self to integration sensor and utility_meter (home-assistant#21226)
  Prevent invalid context from crashing (home-assistant#21231)
  Update pyhomematic to 0.1.56 (home-assistant#21227)
  Fix the build (home-assistant#21229)
  Updated frontend to 20190219.0
  Add yeelight flow action support (home-assistant#21195)
  Refactor ZHA listeners into channels (home-assistant#21196)
  Fix Homematic IP Cloud configuration (home-assistant#21202)
  Push pyads to 3.0.7 (home-assistant#21216)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants