Refactor ZHA listeners into channels#21196
Merged
Merged
Conversation
ghost
assigned
balloob
approved these changes
Feb 19, 2019
This was referenced Feb 20, 2019
balloob
pushed a commit
that referenced
this pull request
Feb 20, 2019
* refactor listeners to channels * update coveragerc
Merged
thibmaek
added a commit
to thibmaek/home-assistant
that referenced
this pull request
Feb 21, 2019
* upstream/dev: (948 commits) Prevent partial custom component overlays (home-assistant#21070) Alarm trigger support for Point (home-assistant#21207) Upgrade opensensemap-api to 0.1.4 (home-assistant#21240) Remove constraint from regex (home-assistant#21239) Updated frontend to 20190220.0 Support OpenWRT 18.06 in luci device tracker (home-assistant#21236) Bump zigpy (home-assistant#21203) Fix bug in ZHA and tweak non sensor channel logic (home-assistant#21234) Don't dispatch to components when there are no channels for ZHA sensors (home-assistant#21223) Add zone and reps for Xiaomi vacuum (home-assistant#19777) Fix an Ambient PWS exception when location info is missing (home-assistant#21220) Add self to integration sensor and utility_meter (home-assistant#21226) Prevent invalid context from crashing (home-assistant#21231) Update pyhomematic to 0.1.56 (home-assistant#21227) Fix the build (home-assistant#21229) Updated frontend to 20190219.0 Add yeelight flow action support (home-assistant#21195) Refactor ZHA listeners into channels (home-assistant#21196) Fix Homematic IP Cloud configuration (home-assistant#21202) Push pyads to 3.0.7 (home-assistant#21216) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames listeners to channels and splits them up between modules that match the Zigpy module structure for clusters. The PR looks huge but there are actually 0 changes being introduced here. All that has been done is to rename "listener" to "channel" across ZHA and the listeners module has been reorganized into separate files. This will eventually be the foundation of full zigbee cluster support for ZHA.
The reason listeners are being renamed to channel is because not all clusters actually report anything. So in those cases (and in the end, the majority of the cases) listeners wouldn't actually be listening to anything. This makes the listener moniker break down so channel is a more appropriate name.
There are empty modules defined as placeholders. If this is a problem I can remove them but they will return shortly anyway...
There is NO need to include this in .88