Fix an Ambient PWS exception when location info is missing#21220
Merged
Conversation
homeassistant
added
cla-signed
integration: ambient_station
small-pr
ghost
added
the
bachya
force-pushed
the
ambient-location-fix
branch
from
bd1c223 to
e1fcd12
Compare
bachya
force-pushed
the
ambient-location-fix
branch
from
e1fcd12 to
37718c3
Compare
MartinHjelmare
approved these changes
Feb 20, 2019
balloob
pushed a commit
that referenced
this pull request
Feb 20, 2019
Merged
thibmaek
added a commit
to thibmaek/home-assistant
that referenced
this pull request
Feb 21, 2019
* upstream/dev: (948 commits) Prevent partial custom component overlays (home-assistant#21070) Alarm trigger support for Point (home-assistant#21207) Upgrade opensensemap-api to 0.1.4 (home-assistant#21240) Remove constraint from regex (home-assistant#21239) Updated frontend to 20190220.0 Support OpenWRT 18.06 in luci device tracker (home-assistant#21236) Bump zigpy (home-assistant#21203) Fix bug in ZHA and tweak non sensor channel logic (home-assistant#21234) Don't dispatch to components when there are no channels for ZHA sensors (home-assistant#21223) Add zone and reps for Xiaomi vacuum (home-assistant#19777) Fix an Ambient PWS exception when location info is missing (home-assistant#21220) Add self to integration sensor and utility_meter (home-assistant#21226) Prevent invalid context from crashing (home-assistant#21231) Update pyhomematic to 0.1.56 (home-assistant#21227) Fix the build (home-assistant#21229) Updated frontend to 20190219.0 Add yeelight flow action support (home-assistant#21195) Refactor ZHA listeners into channels (home-assistant#21196) Fix Homematic IP Cloud configuration (home-assistant#21202) Push pyads to 3.0.7 (home-assistant#21216) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
A user pointed out to me that if an Ambient customer doesn't specify a device name or location name, those fields are removed from the socket response. Currently, that'll throw an unhandled exception. This PR fixes it by defaulting to using the MAC address if no name is provided.
Related issue (if applicable): N/A
Pull request in home-assistant.io with documentation (if applicable): N/A
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests pass