Skip to content

Google assistant fix target temp for *F values. #19083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
balloob merged 5 commits into from
Dec 10, 2018
Merged

Google assistant fix target temp for *F values. #19083

Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ee7114d
home-assistant/home-assistant#18524 : Add rounding to *F temps
marchingphoenix Dec 7, 2018
4ffb9c3
home-assistant/home-assistant#18524 : Linting
marchingphoenix Dec 7, 2018
c128e69
Merge branch 'dev' into google_assistant-fix_target_temp
marchingphoenix Dec 7, 2018
3f7ad7b
simplify round behavior
marchingphoenix Dec 7, 2018
53958a8
fix trailing whitespace
marchingphoenix Dec 7, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 12 additions & 5 deletions homeassistant/components/google_assistant/trait.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,8 +588,11 @@ async def execute(self, command, params):
max_temp = self.state.attributes[climate.ATTR_MAX_TEMP]

if command == COMMAND_THERMOSTAT_TEMPERATURE_SETPOINT:
temp = temp_util.convert(params['thermostatTemperatureSetpoint'],
TEMP_CELSIUS, unit)
temp = temp_util.convert(
params['thermostatTemperatureSetpoint'], TEMP_CELSIUS,
unit)
if unit == TEMP_FAHRENHEIT:
temp = round(temp)

if temp < min_temp or temp > max_temp:
raise SmartHomeError(
Expand All @@ -607,15 +610,19 @@ async def execute(self, command, params):
temp_high = temp_util.convert(
params['thermostatTemperatureSetpointHigh'], TEMP_CELSIUS,
unit)
if unit == TEMP_FAHRENHEIT:
temp_high = round(temp_high)

if temp_high < min_temp or temp_high > max_temp:
raise SmartHomeError(
ERR_VALUE_OUT_OF_RANGE,
"Upper bound for temperature range should be between "
"{} and {}".format(min_temp, max_temp))

"{} and {}".format(min_temp, max_temp))
Comment thread
marchingphoenix marked this conversation as resolved.
Outdated
temp_low = temp_util.convert(
params['thermostatTemperatureSetpointLow'], TEMP_CELSIUS, unit)
params['thermostatTemperatureSetpointLow'], TEMP_CELSIUS,
unit)
if unit == TEMP_FAHRENHEIT:
temp_low = round(temp_low)

if temp_low < min_temp or temp_low > max_temp:
raise SmartHomeError(
Expand Down