Fix multiarch build #290
Fix multiarch build #290
Conversation
improves the Docker build process, GitHub Actions workflow, and plugin dependencies for the Headlamp Kubernetes plugins repository. Signed-off-by: Kirill <[email protected]>
kksudo
force-pushed
the
bugfix/fix-multiarch
branch
from
d4f7d8f to
8f40c05
Compare
Signed-off-by: Kirill <[email protected]>
kksudo
force-pushed
the
bugfix/fix-multiarch
branch
from
c595182 to
d4b75d2
Compare
|
@illume Pls, review this PR |
|
Wow, thanks for all these improvements. Would you mind breaking the changes up into separate commits? With one separate topic per commit. I think the flux package.json version change can be removed from the PR. The release can come later. |
@illume , |
| @@ -1,5 +1,7 @@ | |||
| # Use the official Node.js 18 image as the base image for building the plugins | |||
| FROM node:18@sha256:d0bbfdbad0bff8253e6159dcbee42141db4fc309365d5b8bcfce46ed71569078 AS builder | |||
| ARG BASE_IMAGE_VERSION=18 | |||
There was a problem hiding this comment.
For security reasons we need the full image version with the hash.
| # Use the official Node.js 18 image as the base image for building the plugins | ||
| FROM node:18@sha256:d0bbfdbad0bff8253e6159dcbee42141db4fc309365d5b8bcfce46ed71569078 AS builder | ||
| ARG BASE_IMAGE_VERSION=18 | ||
| ARG FINAL_IMAGE_VERSION=3.20.3 |
There was a problem hiding this comment.
For security reasons we need the full image version with the hash.
There was a problem hiding this comment.
For security reasons we need the full image version with the hash.
Would you like to get the dependabot , which could watch updates and make a PR for the updated docker image versions?
There was a problem hiding this comment.
I thought we had it. I will check it out. But in the current code, we need to keep the hash.
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "@headlamp-k8s/flux", | |||
| "version": "0.2.0", | |||
There was a problem hiding this comment.
Can you remove the flux commits from this PR? I think this should be just about the image building.
There was a problem hiding this comment.
The commit title needs to summarize what this commit does. It does update the docs but it should instead indicate what this is about.
| image: ghcr.io/headlamp-k8s/headlamp-plugin-flux:latest | ||
| imagePullPolicy: Always | ||
| name: headlamp-plugins | ||
| securityContext: |
There was a problem hiding this comment.
Do we need to run this as root?
There was a problem hiding this comment.
Not sure, I guess no.
|
Thanks @kksudo . I think the image building changes for the GH action are nice. I left some comments though. |
Actually, I split this big PR to few small PRs. Should we close this one and use small PRs instead? |
|
Yeah, let's close this one now you have all the other ones :) |
Optimized Docker Builds, Workflow, and Plugin Updates
This PR improves the Docker build process, GitHub Actions workflow, and plugin dependencies for the Headlamp Kubernetes plugins repository.
Main Changes
fluxplugin dependencies to ensure stability.fluxplugin version influx/package.jsonfrom0.2.0to0.2.1.Additional Improvements
.github/workflows/build-and-publish-image.ymlto support building multiple plugins in a single GitHub Actions run using a matrix strategy.ENVIRONMENTis set toproduction..dockerignore: Excludednode_modules,.git, and test files to reduce Docker image size and improve build efficiency.BASE_IMAGE_VERSIONandFINAL_IMAGE_VERSIONarguments in theDockerfileand fixed unsupported Node base image versions..gitignore: Included a.gitignorefile to prevent unnecessary files from being tracked.https://github.com/kksudo/plugins/actions/runs/15802543339
issue links
Error: Cannot find module @rollup/rollup-linux-arm64-gnuhttps://github.com/headlamp-k8s/plugins/actions/runs/14095869941/job/39482966413#step:9:287can't create plugins/flux directoryFlux: v0.2.0 can't create plugins/flux directory #214