Skip to content

Conversation

kksudo
Copy link
Contributor

@kksudo kksudo commented Jun 27, 2025

A new PR to resolve PR conflicts from here #292

Description

  • Optimized Dockerfile: Added logic to skip development dependencies in production builds when ENVIRONMENT is set to production.
  • Added .dockerignore: Excluded node_modules, .git, and test files to reduce Docker image size and improve build efficiency.
  • Configurable Image Versions: Introduced BASE_IMAGE_VERSION and FINAL_IMAGE_VERSION arguments in the Dockerfile and fixed unsupported Node base image versions.

Split this PR.
#290 (comment)

…n builds when ENVIRONMENT is set to production.

Add Dockerignore to keep only necessary files in the docker image

Signed-off-by: Kirill <[email protected]>
(cherry picked from commit f0da980)
Copy link
Contributor

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 thanks! Nice improvements.

@illume illume merged commit 150772c into headlamp-k8s:main Jul 15, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants