Skip to content

Conversation

@kksudo
Copy link
Contributor

@kksudo kksudo commented Jun 22, 2025

Description

Fixed Flux Dependencies: Resolved issues with the flux plugin dependencies to ensure stability.

N.B.: Could be related to these PRs:


Split this PR.
#290 (comment)

improves the Docker build process, GitHub Actions workflow, and plugin dependencies for the Headlamp Kubernetes plugins repository.

Signed-off-by: Kirill <[email protected]>
@illume illume changed the title Fix Flux Dependencies flux: Fix dependencies Jun 23, 2025
@illume
Copy link
Contributor

illume commented Jun 23, 2025

What issue does this solve?

@ashu8912 i think we should update dependencies outside of this PR. I think updates will be handled with a headlamp-plugin update.

@kksudo
Copy link
Contributor Author

kksudo commented Jun 23, 2025

What issue does this solve?

@ashu8912 i think we should update dependencies outside of this PR. I think updates will be handled with a headlamp-plugin update.

Error: Cannot find module @rollup/rollup-linux-arm64-gnu https://github.com/headlamp-k8s/plugins/actions/runs/14095869941/job/39482966413#step:9:287

@kksudo
Copy link
Contributor Author

kksudo commented Jun 23, 2025

i think we should update dependencies outside of this PR. I think updates will be handled with a headlamp-plugin update.

Ok, but without it the GH WF for the ARM based arch did not complete with success.

@illume illume requested a review from ashu8912 June 24, 2025 16:32
@illume illume added the flux flux plugin related issues label Jun 24, 2025
@illume
Copy link
Contributor

illume commented Jun 24, 2025

What issue does this solve?
@ashu8912 i think we should update dependencies outside of this PR. I think updates will be handled with a headlamp-plugin update.

Error: Cannot find module @rollup/rollup-linux-arm64-gnu https://github.com/headlamp-k8s/plugins/actions/runs/14095869941/job/39482966413#step:9:287

Thanks for the info.

This was referenced Jun 25, 2025
Copy link
Member

@ashu8912 ashu8912 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are we handling the missing arm package here? I see a lot of unnecessary changes here

@kksudo
Copy link
Contributor Author

kksudo commented Jul 2, 2025

How are we handling the missing arm package here? I see a lot of unnecessary changes here

From my side, I just run npm install and it helps.
So, I'm not sure if the current PR is till relevant, because another PR from the maintainer should fix this issue.

Btw, You can check my fork with these changes here https://github.com/kksudo/plugins/actions/runs/15802543339.
image
image

@joaquimrocha
Copy link
Contributor

I think this is already fixed after I saw your PRs and submitted similar changes. Can you check @kksudo (and thanks for all these nice PRs, in the end they needed slight changes and we moved with them, but I want to understand if there's anything pending).

@kksudo
Copy link
Contributor Author

kksudo commented Jul 16, 2025

I think this is already fixed after I saw your PRs and submitted similar changes. Can you check @kksudo (and thanks for all these nice PRs, in the end they needed slight changes and we moved with them, but I want to understand if there's anything pending).

Hi, thx for update!
I guess this PR is no more relevant (but I did not test it, because I have overhead of the tasks in another project).

So, I guess we close this PR.

@ashu8912
Copy link
Member

Closing this, this is fixed in main

@ashu8912 ashu8912 closed this Jul 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

flux flux plugin related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants