Skip to content

Conversation

@kksudo
Copy link
Contributor

@kksudo kksudo commented Jun 22, 2025

Description

  • Fixed Multi-Architecture Builds: Corrected multi-architecture build issues for broader platform compatibility.
  • Bumped the version of the BASE NODE image(because the previous one is unsupported by some packages)
  • Add an option to build one, few or all plugins by run one workflow

https://github.com/kksudo/plugins/actions/runs/15802543339
image


Split this PR.
#290 (comment)

This was referenced Jun 22, 2025
Copy link
Contributor

@joaquimrocha joaquimrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @kksudo . I love the changes!
However, the github actions and container images need to be used with hashes. Can you update it to use that?

@joaquimrocha
Copy link
Contributor

Also please make the commit title as:
Dockerfile: Optimize Docker build for different arches

@kksudo kksudo force-pushed the feat/multiarch-build branch 2 times, most recently from 7771525 to 9c3ef94 Compare June 27, 2025 11:43
kksudo added 2 commits June 27, 2025 14:44
improves the Docker build process, GitHub Actions workflow, and plugin dependencies for the Headlamp Kubernetes plugins repository.

Signed-off-by: Kirill <[email protected]>
@kksudo kksudo force-pushed the feat/multiarch-build branch from 9c3ef94 to 6c54666 Compare June 27, 2025 11:44
@kksudo
Copy link
Contributor Author

kksudo commented Jun 27, 2025

Also please make the commit title as: Dockerfile: Optimize Docker build for different arches

Done

@joaquimrocha
Copy link
Contributor

Thank you. I'll test it later today.

@kksudo
Copy link
Contributor Author

kksudo commented Jun 27, 2025

Thank you. I'll test it later today.

Btw, feel free to ask any new DevOps based features. I would be happy to implement it for your project.

@joaquimrocha joaquimrocha changed the base branch from main to multi-arch-matrix-docker June 27, 2025 14:31
@joaquimrocha joaquimrocha merged commit b1f2b69 into headlamp-k8s:multi-arch-matrix-docker Jun 27, 2025
13 checks passed
@joaquimrocha
Copy link
Contributor

@kksudo , BTW, I merged the PR into a non-main branch so I could test it from there. The build seems to have failed:
https://github.com/headlamp-k8s/plugins/actions/runs/15929038410/job/44933393772

@kksudo
Copy link
Contributor Author

kksudo commented Jun 27, 2025

@joaquimrocha FYI, I mentioned this issue:
https://github.com/headlamp-k8s/plugins/actions/runs/15929038410/job/44933393772#step:8:508

#294 (comment)

The fix in this PR #294

P.S.: It's not directly related to my changes, it's an issue with the decencies in the npm and in the NODE version as well....
To verify it, you can find all these changes in my fork : https://github.com/kksudo/plugins/actions/runs/15802543339

All steps are green
image

@kksudo
Copy link
Contributor Author

kksudo commented Jun 27, 2025

@kksudo , BTW, I merged the PR into a non-main branch so I could test it from there. The build seems to have failed: https://github.com/headlamp-k8s/plugins/actions/runs/15929038410/job/44933393772

The reason is decencies, that it's why initially I've created all these changes in one PR here #289

@kksudo
Copy link
Contributor Author

kksudo commented Jun 27, 2025

@joaquimrocha If you need, we can make a call later on, I can explain all changes if you need.

@joaquimrocha
Copy link
Contributor

@kksudo , sorry. Too many PRs. I didn't notice that they were related to such point.
Can you tell me how you updated the dependencies? package-lock.json updates are difficult to review and disclosing what command was used to generate those helps us review it more easily.
For now I will try to push an image in the current way, then we can update the dependencies + a few pending PRs for Flux and release again next week.
It should go faster now since I have a new script to help automate it.

@kksudo
Copy link
Contributor Author

kksudo commented Jun 27, 2025

Can you tell me how you updated the dependencies? package-lock.json updates are difficult to review and disclosing what command was used to generate those helps us review it more easily.

Just npm install

@kksudo
Copy link
Contributor Author

kksudo commented Jun 27, 2025

@kksudo , sorry. Too many PRs.

Because your product is pretty popular

@joaquimrocha
Copy link
Contributor

Because your product is pretty popular

haha, yeah. We are still getting used to the increase in the load. Definitely a great problem to have 🙂

Can you tell me how you updated the dependencies? package-lock.json updates are difficult to review and disclosing what command was used to generate those helps us review it more easily.

Just npm install

Hmm, in this case then we should have it already in the main branch, since when the flux release was bumped, it ran npm install.

@joaquimrocha
Copy link
Contributor

@kksudo Are you in the Kubernetes Slack? I would like to chat directly, in order to sort out a few questions.

@kksudo
Copy link
Contributor Author

kksudo commented Jun 28, 2025

@kksudo Are you in the Kubernetes Slack? I would like to chat directly, in order to sort out a few questions.

https://kubernetes.slack.com/team/UQQ8Q4SEL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants