-
Couldn't load subscription status.
- Fork 36
Optimized Docker Builds, Workflow, #293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optimized Docker Builds, Workflow, #293
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @kksudo . I love the changes!
However, the github actions and container images need to be used with hashes. Can you update it to use that?
|
Also please make the commit title as: |
7771525 to
9c3ef94
Compare
improves the Docker build process, GitHub Actions workflow, and plugin dependencies for the Headlamp Kubernetes plugins repository. Signed-off-by: Kirill <[email protected]>
Signed-off-by: Kirill <[email protected]>
9c3ef94 to
6c54666
Compare
Done |
|
Thank you. I'll test it later today. |
Btw, feel free to ask any new DevOps based features. I would be happy to implement it for your project. |
b1f2b69
into
headlamp-k8s:multi-arch-matrix-docker
|
@kksudo , BTW, I merged the PR into a non-main branch so I could test it from there. The build seems to have failed: |
|
@joaquimrocha FYI, I mentioned this issue: The fix in this PR #294 P.S.: It's not directly related to my changes, it's an issue with the decencies in the npm and in the NODE version as well.... |
The reason is decencies, that it's why initially I've created all these changes in one PR here #289 |
|
@joaquimrocha If you need, we can make a call later on, I can explain all changes if you need. |
|
@kksudo , sorry. Too many PRs. I didn't notice that they were related to such point. |
Just |
Because your product is pretty popular |
haha, yeah. We are still getting used to the increase in the load. Definitely a great problem to have 🙂
Hmm, in this case then we should have it already in the main branch, since when the flux release was bumped, it ran npm install. |
|
@kksudo Are you in the Kubernetes Slack? I would like to chat directly, in order to sort out a few questions. |
|

Description
https://github.com/kksudo/plugins/actions/runs/15802543339

Split this PR.
#290 (comment)