`aws_default_vpc` and `aws_default_subnet`: Full lifecycle #22253

dirk39 · 2021-12-16T13:09:42Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #4959
Closes #4957
Closes #13859
Closes #13951
Closes #14911
Closes #17458
Closes #21241
Relates #8302
Relates #20433
Relates #22776

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccEC2DefaultVPC_' PKG=ec2

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2DefaultVPC_ -timeout 180m
=== RUN   TestAccEC2DefaultVPC_basic
=== PAUSE TestAccEC2DefaultVPC_basic
=== CONT  TestAccEC2DefaultVPC_basic
--- PASS: TestAccEC2DefaultVPC_basic (26.16s)
PASS
ok

To run the test, I have to delete the existing default VPC, or I get an error. Is there a better way to do this without repeating the delete function in the test environment? Thanks

Acceptance test output: % AWS_DEFAULT_REGION=eu-west-2 make testacc TESTARGS='-run=TestAccEC2DefaultSubnet_basic' PKG_NAME=internal/service/ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2DefaultSubnet_basic -timeout 180m === RUN TestAccEC2DefaultSubnet_basic === PAUSE TestAccEC2DefaultSubnet_basic === CONT TestAccEC2DefaultSubnet_basic default_subnet_test.go:17: Step 1/1 error: After applying this test step, the plan was not empty. stdout: Terraform used the selected providers to generate the following execution plan. Resource actions are indicated with the following symbols: ~ update in-place Terraform will perform the following actions: # aws_default_subnet.test will be updated in-place ~ resource "aws_default_subnet" "test" { id = "subnet-5e636b26" ~ map_public_ip_on_launch = true -> false # (15 unchanged attributes hidden) } Plan: 0 to add, 1 to change, 0 to destroy. --- FAIL: TestAccEC2DefaultSubnet_basic (10.19s) FAIL FAIL github.com/hashicorp/terraform-provider-aws/internal/service/ec2 13.707s FAIL make: *** [testacc] Error 1

…as... Acceptance test output: % AWS_DEFAULT_REGION=eu-west-2 make testacc TESTARGS='-run=TestAccEC2DefaultSubnet_basic' PKG_NAME=internal/service/ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2DefaultSubnet_basic -timeout 180m === RUN TestAccEC2DefaultSubnet_basic === PAUSE TestAccEC2DefaultSubnet_basic === CONT TestAccEC2DefaultSubnet_basic --- PASS: TestAccEC2DefaultSubnet_basic (26.14s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 29.867s

Acceptance test output: % AWS_DEFAULT_REGION=eu-west-2 make testacc TESTARGS='-run=TestAccEC2DefaultSubnet_basic' PKG_NAME=internal/service/ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2DefaultSubnet_basic -timeout 180m === RUN TestAccEC2DefaultSubnet_basic === PAUSE TestAccEC2DefaultSubnet_basic === CONT TestAccEC2DefaultSubnet_basic --- PASS: TestAccEC2DefaultSubnet_basic (16.30s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 20.128s % make testacc TESTARGS='-run=TestAccEC2Subnet_' PKG=ec2 ACCTEST_PARALLELISM=5 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 5 -run=TestAccEC2Subnet_ -timeout 180m === RUN TestAccEC2Subnet_basic === PAUSE TestAccEC2Subnet_basic === RUN TestAccEC2Subnet_tags === PAUSE TestAccEC2Subnet_tags === RUN TestAccEC2Subnet_DefaultTags_providerOnly === PAUSE TestAccEC2Subnet_DefaultTags_providerOnly === RUN TestAccEC2Subnet_DefaultTags_updateToProviderOnly === PAUSE TestAccEC2Subnet_DefaultTags_updateToProviderOnly === RUN TestAccEC2Subnet_DefaultTags_updateToResourceOnly === PAUSE TestAccEC2Subnet_DefaultTags_updateToResourceOnly === RUN TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag === PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag === RUN TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag === PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag === RUN TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag === PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag === RUN TestAccEC2Subnet_defaultAndIgnoreTags === PAUSE TestAccEC2Subnet_defaultAndIgnoreTags === RUN TestAccEC2Subnet_updateTagsKnownAtApply === PAUSE TestAccEC2Subnet_updateTagsKnownAtApply === RUN TestAccEC2Subnet_ignoreTags === PAUSE TestAccEC2Subnet_ignoreTags === RUN TestAccEC2Subnet_ipv6 === PAUSE TestAccEC2Subnet_ipv6 === RUN TestAccEC2Subnet_enableIPv6 === PAUSE TestAccEC2Subnet_enableIPv6 === RUN TestAccEC2Subnet_availabilityZoneID === PAUSE TestAccEC2Subnet_availabilityZoneID === RUN TestAccEC2Subnet_disappears === PAUSE TestAccEC2Subnet_disappears === RUN TestAccEC2Subnet_customerOwnedIPv4Pool === PAUSE TestAccEC2Subnet_customerOwnedIPv4Pool === RUN TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch === PAUSE TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch === RUN TestAccEC2Subnet_mapPublicIPOnLaunch === PAUSE TestAccEC2Subnet_mapPublicIPOnLaunch === RUN TestAccEC2Subnet_outpost === PAUSE TestAccEC2Subnet_outpost === RUN TestAccEC2Subnet_enableDNS64 === PAUSE TestAccEC2Subnet_enableDNS64 === RUN TestAccEC2Subnet_privateDnsNameOptionsOnLaunch === PAUSE TestAccEC2Subnet_privateDnsNameOptionsOnLaunch === RUN TestAccEC2Subnet_ipv6Native === PAUSE TestAccEC2Subnet_ipv6Native === CONT TestAccEC2Subnet_basic === CONT TestAccEC2Subnet_enableIPv6 === CONT TestAccEC2Subnet_ipv6Native === CONT TestAccEC2Subnet_privateDnsNameOptionsOnLaunch === CONT TestAccEC2Subnet_enableDNS64 --- PASS: TestAccEC2Subnet_basic (36.19s) === CONT TestAccEC2Subnet_outpost --- PASS: TestAccEC2Subnet_ipv6Native (36.51s) === CONT TestAccEC2Subnet_mapPublicIPOnLaunch === CONT TestAccEC2Subnet_outpost acctest.go:1254: skipping since no Outposts found --- SKIP: TestAccEC2Subnet_outpost (0.62s) === CONT TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch acctest.go:1254: skipping since no Outposts found --- SKIP: TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch (0.55s) === CONT TestAccEC2Subnet_customerOwnedIPv4Pool acctest.go:1254: skipping since no Outposts found --- SKIP: TestAccEC2Subnet_customerOwnedIPv4Pool (0.60s) === CONT TestAccEC2Subnet_disappears --- PASS: TestAccEC2Subnet_disappears (27.28s) === CONT TestAccEC2Subnet_availabilityZoneID --- PASS: TestAccEC2Subnet_availabilityZoneID (31.74s) === CONT TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag --- PASS: TestAccEC2Subnet_enableIPv6 (105.09s) === CONT TestAccEC2Subnet_ipv6 --- PASS: TestAccEC2Subnet_enableDNS64 (123.19s) === CONT TestAccEC2Subnet_ignoreTags --- PASS: TestAccEC2Subnet_mapPublicIPOnLaunch (110.55s) === CONT TestAccEC2Subnet_updateTagsKnownAtApply --- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag (77.30s) === CONT TestAccEC2Subnet_defaultAndIgnoreTags --- PASS: TestAccEC2Subnet_privateDnsNameOptionsOnLaunch (181.07s) === CONT TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag --- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag (2.01s) === CONT TestAccEC2Subnet_DefaultTags_updateToProviderOnly --- PASS: TestAccEC2Subnet_ignoreTags (63.57s) === CONT TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag --- PASS: TestAccEC2Subnet_ipv6 (105.70s) === CONT TestAccEC2Subnet_DefaultTags_updateToResourceOnly --- PASS: TestAccEC2Subnet_updateTagsKnownAtApply (77.98s) === CONT TestAccEC2Subnet_DefaultTags_providerOnly --- PASS: TestAccEC2Subnet_DefaultTags_updateToProviderOnly (62.21s) === CONT TestAccEC2Subnet_tags --- PASS: TestAccEC2Subnet_defaultAndIgnoreTags (72.81s) --- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag (83.96s) --- PASS: TestAccEC2Subnet_DefaultTags_updateToResourceOnly (60.94s) --- PASS: TestAccEC2Subnet_DefaultTags_providerOnly (80.64s) --- PASS: TestAccEC2Subnet_tags (77.07s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 328.734s

Acceptance test output: % make testacc TESTARGS='-run=TestAccEC2DefaultSubnet_basic' PKG_NAME=internal/service/ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2DefaultSubnet_basic -timeout 180m === RUN TestAccEC2DefaultSubnet_basic === PAUSE TestAccEC2DefaultSubnet_basic === CONT TestAccEC2DefaultSubnet_basic --- PASS: TestAccEC2DefaultSubnet_basic (14.52s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 18.126s

Acceptance test output: % make testacc TESTARGS='-run=TestAccEC2DefaultSubnet_basic' PKG_NAME=internal/service/ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2DefaultSubnet_basic -timeout 180m === RUN TestAccEC2DefaultSubnet_basic === PAUSE TestAccEC2DefaultSubnet_basic === CONT TestAccEC2DefaultSubnet_basic --- PASS: TestAccEC2DefaultSubnet_basic (14.92s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 18.662s % make testacc TESTARGS='-run=TestAccEC2Subnet_' PKG=ec2 ACCTEST_PARALLELISM=5 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 5 -run=TestAccEC2Subnet_ -timeout 180m === RUN TestAccEC2Subnet_basic === PAUSE TestAccEC2Subnet_basic === RUN TestAccEC2Subnet_tags === PAUSE TestAccEC2Subnet_tags === RUN TestAccEC2Subnet_DefaultTags_providerOnly === PAUSE TestAccEC2Subnet_DefaultTags_providerOnly === RUN TestAccEC2Subnet_DefaultTags_updateToProviderOnly === PAUSE TestAccEC2Subnet_DefaultTags_updateToProviderOnly === RUN TestAccEC2Subnet_DefaultTags_updateToResourceOnly === PAUSE TestAccEC2Subnet_DefaultTags_updateToResourceOnly === RUN TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag === PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag === RUN TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag === PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag === RUN TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag === PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag === RUN TestAccEC2Subnet_defaultAndIgnoreTags === PAUSE TestAccEC2Subnet_defaultAndIgnoreTags === RUN TestAccEC2Subnet_updateTagsKnownAtApply === PAUSE TestAccEC2Subnet_updateTagsKnownAtApply === RUN TestAccEC2Subnet_ignoreTags === PAUSE TestAccEC2Subnet_ignoreTags === RUN TestAccEC2Subnet_ipv6 === PAUSE TestAccEC2Subnet_ipv6 === RUN TestAccEC2Subnet_enableIPv6 === PAUSE TestAccEC2Subnet_enableIPv6 === RUN TestAccEC2Subnet_availabilityZoneID === PAUSE TestAccEC2Subnet_availabilityZoneID === RUN TestAccEC2Subnet_disappears === PAUSE TestAccEC2Subnet_disappears === RUN TestAccEC2Subnet_customerOwnedIPv4Pool === PAUSE TestAccEC2Subnet_customerOwnedIPv4Pool === RUN TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch === PAUSE TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch === RUN TestAccEC2Subnet_mapPublicIPOnLaunch === PAUSE TestAccEC2Subnet_mapPublicIPOnLaunch === RUN TestAccEC2Subnet_outpost === PAUSE TestAccEC2Subnet_outpost === RUN TestAccEC2Subnet_enableDNS64 === PAUSE TestAccEC2Subnet_enableDNS64 === RUN TestAccEC2Subnet_privateDnsNameOptionsOnLaunch === PAUSE TestAccEC2Subnet_privateDnsNameOptionsOnLaunch === RUN TestAccEC2Subnet_ipv6Native === PAUSE TestAccEC2Subnet_ipv6Native === CONT TestAccEC2Subnet_basic === CONT TestAccEC2Subnet_ipv6Native === CONT TestAccEC2Subnet_ipv6 === CONT TestAccEC2Subnet_privateDnsNameOptionsOnLaunch === CONT TestAccEC2Subnet_customerOwnedIPv4Pool acctest.go:1254: skipping since no Outposts found --- SKIP: TestAccEC2Subnet_customerOwnedIPv4Pool (1.37s) === CONT TestAccEC2Subnet_disappears --- PASS: TestAccEC2Subnet_disappears (23.43s) === CONT TestAccEC2Subnet_availabilityZoneID --- PASS: TestAccEC2Subnet_basic (27.28s) === CONT TestAccEC2Subnet_enableIPv6 --- PASS: TestAccEC2Subnet_ipv6Native (28.20s) === CONT TestAccEC2Subnet_outpost acctest.go:1254: skipping since no Outposts found --- SKIP: TestAccEC2Subnet_outpost (0.61s) === CONT TestAccEC2Subnet_enableDNS64 --- PASS: TestAccEC2Subnet_availabilityZoneID (27.75s) === CONT TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch acctest.go:1254: skipping since no Outposts found --- SKIP: TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch (0.56s) === CONT TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag --- PASS: TestAccEC2Subnet_ipv6 (88.78s) === CONT TestAccEC2Subnet_mapPublicIPOnLaunch --- PASS: TestAccEC2Subnet_enableIPv6 (86.63s) === CONT TestAccEC2Subnet_ignoreTags --- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag (61.66s) === CONT TestAccEC2Subnet_updateTagsKnownAtApply --- PASS: TestAccEC2Subnet_enableDNS64 (108.53s) === CONT TestAccEC2Subnet_defaultAndIgnoreTags --- PASS: TestAccEC2Subnet_privateDnsNameOptionsOnLaunch (166.30s) === CONT TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag --- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag (1.07s) === CONT TestAccEC2Subnet_DefaultTags_updateToProviderOnly --- PASS: TestAccEC2Subnet_ignoreTags (53.90s) === CONT TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag --- PASS: TestAccEC2Subnet_updateTagsKnownAtApply (64.59s) === CONT TestAccEC2Subnet_DefaultTags_updateToResourceOnly --- PASS: TestAccEC2Subnet_mapPublicIPOnLaunch (98.55s) === CONT TestAccEC2Subnet_DefaultTags_providerOnly --- PASS: TestAccEC2Subnet_defaultAndIgnoreTags (57.14s) === CONT TestAccEC2Subnet_tags --- PASS: TestAccEC2Subnet_DefaultTags_updateToProviderOnly (43.11s) --- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag (56.84s) --- PASS: TestAccEC2Subnet_DefaultTags_updateToResourceOnly (47.42s) --- PASS: TestAccEC2Subnet_DefaultTags_providerOnly (62.50s) --- PASS: TestAccEC2Subnet_tags (63.53s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 261.856s

Signed-off-by: Andrea Quintino <[email protected]>

Signed-off-by: dirk39 <[email protected]>

This reverts commit 068311abc61af4ed43c841ffbce2b70690aec271.

This reverts commit 8d7b56c2e0058c52a14008d5ffdd8fdee46318c4.

This reverts commit b415b4808674068c3631f21ae4e4170aeb85720c.

This reverts commit 972ff5e0e36be04287a5091bd2d5c58c87564618.

This reverts commit d74c36cdc05338b62c02df5244661e38ade6b4ab.

This reverts commit 484f2921324b8fb202f396a8ac99d85bafa6d429.

…cle' into HEAD

…eAttrGreaterThanValue'.

…onsOnLaunch'. % make testacc TESTS=TestAccEC2DefaultVPCAndSubnet_serial/Subnet/privateDnsNameOptionsOnLaunch PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2DefaultVPCAndSubnet_serial/Subnet/privateDnsNameOptionsOnLaunch' -timeout 180m === RUN TestAccEC2DefaultVPCAndSubnet_serial === RUN TestAccEC2DefaultVPCAndSubnet_serial/Subnet === RUN TestAccEC2DefaultVPCAndSubnet_serial/Subnet/privateDnsNameOptionsOnLaunch --- PASS: TestAccEC2DefaultVPCAndSubnet_serial (48.51s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet (48.51s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/privateDnsNameOptionsOnLaunch (48.51s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 52.165s

% AWS_DEFAULT_REGION=eu-west-2 make testacc TESTS=TestAccEC2DefaultVPCAndSubnet_serial/VPC PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2DefaultVPCAndSubnet_serial/VPC' -timeout 180m === RUN TestAccEC2DefaultVPCAndSubnet_serial === RUN TestAccEC2DefaultVPCAndSubnet_serial/VPC === RUN TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.basic === RUN TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.assignGeneratedIPv6CIDRBlock === RUN TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.forceDestroy === RUN TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.basic default_vpc_test.go:56: Deleting existing default VPC: vpc-0952d31628cc2a7ba === RUN TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.assignGeneratedIPv6CIDRBlock default_vpc_test.go:56: Deleting existing default VPC: vpc-07b89ae85c358b75f === RUN TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.forceDestroy default_vpc_test.go:56: Deleting existing default VPC: vpc-0599d53adb4a24651 --- PASS: TestAccEC2DefaultVPCAndSubnet_serial (203.38s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC (203.38s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.basic (22.97s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.assignGeneratedIPv6CIDRBlock (33.03s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.forceDestroy (50.79s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.basic (25.39s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.assignGeneratedIPv6CIDRBlock (36.82s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.forceDestroy (34.38s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 207.630s

% AWS_DEFAULT_REGION=eu-west-2 make testacc TESTS=TestAccEC2DefaultVPCAndSubnet_serial/Subnet PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2DefaultVPCAndSubnet_serial/Subnet' -timeout 180m === RUN TestAccEC2DefaultVPCAndSubnet_serial === RUN TestAccEC2DefaultVPCAndSubnet_serial/Subnet === RUN TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.privateDnsNameOptionsOnLaunch === RUN TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.basic === RUN TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.ipv6 --- PASS: TestAccEC2DefaultVPCAndSubnet_serial (150.53s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet (150.53s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.privateDnsNameOptionsOnLaunch (29.08s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.basic (28.64s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.ipv6 (92.81s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 154.075s

% AWS_DEFAULT_REGION=eu-west-2 make testacc TESTS=TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing' -timeout 180m === RUN TestAccEC2DefaultVPCAndSubnet_serial === RUN TestAccEC2DefaultVPCAndSubnet_serial/Subnet === RUN TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.privateDnsNameOptionsOnLaunch === RUN TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.basic === RUN TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.forceDestroy === RUN TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.ipv6 --- PASS: TestAccEC2DefaultVPCAndSubnet_serial (192.57s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet (192.57s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.privateDnsNameOptionsOnLaunch (49.32s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.basic (33.13s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.forceDestroy (19.62s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.ipv6 (90.50s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 199.777s

…in the standard region(s) as other resources' tests (e.g. aws_instance) implicitly use default subnets. Acceptance test output: % AWS_DEFAULT_REGION=eu-west-2 make testacc TESTS=TestAccEC2DefaultVPCAndSubnet_serial PKG=ec2 ==> Checking that code complies with gofmt requirements... TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2DefaultVPCAndSubnet_serial' -timeout 180m === RUN TestAccEC2DefaultVPCAndSubnet_serial === RUN TestAccEC2DefaultVPCAndSubnet_serial/VPC === RUN TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.basic === RUN TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.assignGeneratedIPv6CIDRBlock === RUN TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.forceDestroy === RUN TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.basic default_vpc_test.go:61: Deleting existing default VPC: vpc-070f87de6a2504c87 === RUN TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.assignGeneratedIPv6CIDRBlock default_vpc_test.go:61: Deleting existing default VPC: vpc-08068b0353ebbae41 === RUN TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.forceDestroy default_vpc_test.go:61: Deleting existing default VPC: vpc-09610d2f3e1ffba00 === RUN TestAccEC2DefaultVPCAndSubnet_serial/Subnet === RUN TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.forceDestroy === RUN TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.ipv6 === RUN TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.privateDnsNameOptionsOnLaunch === RUN TestAccEC2DefaultVPCAndSubnet_serial/Subnet/notFound.basic default_subnet_test.go:62: Deleting existing default subnet: subnet-0a60a9666d2edfb92 default_subnet_test.go:62: Deleting existing default subnet: subnet-0d5b5572150325e38 default_subnet_test.go:62: Deleting existing default subnet: subnet-055f31bb2650e3b86 === RUN TestAccEC2DefaultVPCAndSubnet_serial/Subnet/notFound.ipv6Native default_subnet_test.go:62: Deleting existing default subnet: subnet-07b62a14e35e531c8 default_subnet_test.go:62: Deleting existing default subnet: subnet-03e145e9e3a5db6e6 default_subnet_test.go:62: Deleting existing default subnet: subnet-0e2ba115852876dc6 === RUN TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.basic --- PASS: TestAccEC2DefaultVPCAndSubnet_serial (467.10s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC (233.68s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.basic (46.26s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.assignGeneratedIPv6CIDRBlock (32.89s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.forceDestroy (52.24s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.basic (27.52s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.assignGeneratedIPv6CIDRBlock (40.93s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.forceDestroy (33.84s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet (233.42s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.forceDestroy (22.89s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.ipv6 (64.95s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.privateDnsNameOptionsOnLaunch (41.24s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/notFound.basic (21.50s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/notFound.ipv6Native (64.50s) --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.basic (18.33s) PASS ok github.com/hashicorp/terraform-provider-aws/internal/service/ec2 470.792s

ewbankkit

LGTM 🚀.

Commercial

% AWS_DEFAULT_REGION=eu-west-2 make testacc TESTS=TestAccEC2DefaultVPCAndSubnet_serial PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2DefaultVPCAndSubnet_serial'  -timeout 180m
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.basic
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.assignGeneratedIPv6CIDRBlock
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.forceDestroy
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.basic
    default_vpc_test.go:61: Deleting existing default VPC: vpc-070f87de6a2504c87
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.assignGeneratedIPv6CIDRBlock
    default_vpc_test.go:61: Deleting existing default VPC: vpc-08068b0353ebbae41
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.forceDestroy
    default_vpc_test.go:61: Deleting existing default VPC: vpc-09610d2f3e1ffba00
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.forceDestroy
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.ipv6
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.privateDnsNameOptionsOnLaunch
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/notFound.basic
    default_subnet_test.go:62: Deleting existing default subnet: subnet-0a60a9666d2edfb92
    default_subnet_test.go:62: Deleting existing default subnet: subnet-0d5b5572150325e38
    default_subnet_test.go:62: Deleting existing default subnet: subnet-055f31bb2650e3b86
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/notFound.ipv6Native
    default_subnet_test.go:62: Deleting existing default subnet: subnet-07b62a14e35e531c8
    default_subnet_test.go:62: Deleting existing default subnet: subnet-03e145e9e3a5db6e6
    default_subnet_test.go:62: Deleting existing default subnet: subnet-0e2ba115852876dc6
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.basic
--- PASS: TestAccEC2DefaultVPCAndSubnet_serial (467.10s)
    --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC (233.68s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.basic (46.26s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.assignGeneratedIPv6CIDRBlock (32.89s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.forceDestroy (52.24s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.basic (27.52s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.assignGeneratedIPv6CIDRBlock (40.93s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.forceDestroy (33.84s)
    --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet (233.42s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.forceDestroy (22.89s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.ipv6 (64.95s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.privateDnsNameOptionsOnLaunch (41.24s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/notFound.basic (21.50s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/notFound.ipv6Native (64.50s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.basic (18.33s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	470.792s
% make testacc TESTARGS='-run=TestAccEC2Subnet_' PKG=ec2 ACCTEST_PARALLELISM=5
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 5  -run=TestAccEC2Subnet_ -timeout 180m
=== RUN   TestAccEC2Subnet_basic
=== PAUSE TestAccEC2Subnet_basic
=== RUN   TestAccEC2Subnet_tags
=== PAUSE TestAccEC2Subnet_tags
=== RUN   TestAccEC2Subnet_DefaultTags_providerOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_providerOnly
=== RUN   TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== RUN   TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== PAUSE TestAccEC2Subnet_DefaultTags_updateToResourceOnly
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccEC2Subnet_defaultAndIgnoreTags
=== PAUSE TestAccEC2Subnet_defaultAndIgnoreTags
=== RUN   TestAccEC2Subnet_updateTagsKnownAtApply
=== PAUSE TestAccEC2Subnet_updateTagsKnownAtApply
=== RUN   TestAccEC2Subnet_ignoreTags
=== PAUSE TestAccEC2Subnet_ignoreTags
=== RUN   TestAccEC2Subnet_ipv6
=== PAUSE TestAccEC2Subnet_ipv6
=== RUN   TestAccEC2Subnet_enableIPv6
=== PAUSE TestAccEC2Subnet_enableIPv6
=== RUN   TestAccEC2Subnet_availabilityZoneID
=== PAUSE TestAccEC2Subnet_availabilityZoneID
=== RUN   TestAccEC2Subnet_disappears
=== PAUSE TestAccEC2Subnet_disappears
=== RUN   TestAccEC2Subnet_customerOwnedIPv4Pool
=== PAUSE TestAccEC2Subnet_customerOwnedIPv4Pool
=== RUN   TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== PAUSE TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
=== RUN   TestAccEC2Subnet_mapPublicIPOnLaunch
=== PAUSE TestAccEC2Subnet_mapPublicIPOnLaunch
=== RUN   TestAccEC2Subnet_outpost
=== PAUSE TestAccEC2Subnet_outpost
=== RUN   TestAccEC2Subnet_enableDNS64
=== PAUSE TestAccEC2Subnet_enableDNS64
=== RUN   TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
=== PAUSE TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
=== RUN   TestAccEC2Subnet_ipv6Native
=== PAUSE TestAccEC2Subnet_ipv6Native
=== CONT  TestAccEC2Subnet_basic
=== CONT  TestAccEC2Subnet_ipv6
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag
=== CONT  TestAccEC2Subnet_DefaultTags_updateToProviderOnly
=== CONT  TestAccEC2Subnet_updateTagsKnownAtApply
--- PASS: TestAccEC2Subnet_basic (27.45s)
=== CONT  TestAccEC2Subnet_DefaultTags_providerOnly
--- PASS: TestAccEC2Subnet_DefaultTags_updateToProviderOnly (43.65s)
=== CONT  TestAccEC2Subnet_ignoreTags
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_overlappingTag (60.76s)
=== CONT  TestAccEC2Subnet_tags
--- PASS: TestAccEC2Subnet_updateTagsKnownAtApply (66.07s)
=== CONT  TestAccEC2Subnet_defaultAndIgnoreTags
--- PASS: TestAccEC2Subnet_DefaultTags_providerOnly (61.07s)
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_duplicateTag (1.11s)
=== CONT  TestAccEC2Subnet_privateDnsNameOptionsOnLaunch
--- PASS: TestAccEC2Subnet_ignoreTags (51.43s)
=== CONT  TestAccEC2Subnet_mapPublicIPOnLaunch
--- PASS: TestAccEC2Subnet_ipv6 (97.64s)
=== CONT  TestAccEC2Subnet_ipv6Native
=== CONT  TestAccEC2Subnet_enableDNS64
--- PASS: TestAccEC2Subnet_defaultAndIgnoreTags (52.64s)
--- PASS: TestAccEC2Subnet_tags (61.40s)
=== CONT  TestAccEC2Subnet_outpost
    acctest.go:1264: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_outpost (0.77s)
=== CONT  TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag
--- PASS: TestAccEC2Subnet_ipv6Native (37.10s)
=== CONT  TestAccEC2Subnet_availabilityZoneID
--- PASS: TestAccEC2Subnet_availabilityZoneID (27.79s)
=== CONT  TestAccEC2Subnet_disappears
--- PASS: TestAccEC2Subnet_DefaultTagsProviderAndResource_nonOverlappingTag (53.93s)
=== CONT  TestAccEC2Subnet_enableIPv6
--- PASS: TestAccEC2Subnet_disappears (21.63s)
=== CONT  TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch
    acctest.go:1264: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_mapCustomerOwnedIPOnLaunch (0.61s)
=== CONT  TestAccEC2Subnet_DefaultTags_updateToResourceOnly
--- PASS: TestAccEC2Subnet_mapPublicIPOnLaunch (95.49s)
=== CONT  TestAccEC2Subnet_customerOwnedIPv4Pool
    acctest.go:1264: skipping since no Outposts found
--- SKIP: TestAccEC2Subnet_customerOwnedIPv4Pool (0.64s)
--- PASS: TestAccEC2Subnet_DefaultTags_updateToResourceOnly (47.40s)
--- PASS: TestAccEC2Subnet_enableDNS64 (114.68s)
--- PASS: TestAccEC2Subnet_privateDnsNameOptionsOnLaunch (171.11s)
--- PASS: TestAccEC2Subnet_enableIPv6 (92.73s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	273.201s
% make testacc TESTARGS='-run=TestAccEC2VPCsDataSource_' PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20  -run=TestAccEC2VPCsDataSource_ -timeout 180m
=== RUN   TestAccEC2VPCsDataSource_basic
=== PAUSE TestAccEC2VPCsDataSource_basic
=== RUN   TestAccEC2VPCsDataSource_tags
=== PAUSE TestAccEC2VPCsDataSource_tags
=== RUN   TestAccEC2VPCsDataSource_filters
=== PAUSE TestAccEC2VPCsDataSource_filters
=== RUN   TestAccEC2VPCsDataSource_empty
=== PAUSE TestAccEC2VPCsDataSource_empty
=== CONT  TestAccEC2VPCsDataSource_basic
=== CONT  TestAccEC2VPCsDataSource_filters
=== CONT  TestAccEC2VPCsDataSource_tags
=== CONT  TestAccEC2VPCsDataSource_empty
--- PASS: TestAccEC2VPCsDataSource_empty (11.62s)
--- PASS: TestAccEC2VPCsDataSource_basic (22.53s)
--- PASS: TestAccEC2VPCsDataSource_filters (23.27s)
--- PASS: TestAccEC2VPCsDataSource_tags (23.34s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	26.744s
% make testacc TESTARGS='-run=TestAccVPC_ -short' PKG=ec2 ACCTEST_PARALLELISM=4
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 4  -run=TestAccVPC_ -short -timeout 180m
=== RUN   TestAccVPC_basic
=== PAUSE TestAccVPC_basic
=== RUN   TestAccVPC_disappears
=== PAUSE TestAccVPC_disappears
=== RUN   TestAccVPC_tags
=== PAUSE TestAccVPC_tags
=== RUN   TestAccVPC_DefaultTags_providerOnly
=== PAUSE TestAccVPC_DefaultTags_providerOnly
=== RUN   TestAccVPC_DefaultTags_updateToProviderOnly
=== PAUSE TestAccVPC_DefaultTags_updateToProviderOnly
=== RUN   TestAccVPC_DefaultTags_updateToResourceOnly
=== PAUSE TestAccVPC_DefaultTags_updateToResourceOnly
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
=== RUN   TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
=== PAUSE TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
=== RUN   TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
=== PAUSE TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
=== RUN   TestAccVPC_DynamicResourceTags_ignoreChanges
=== PAUSE TestAccVPC_DynamicResourceTags_ignoreChanges
=== RUN   TestAccVPC_defaultAndIgnoreTags
=== PAUSE TestAccVPC_defaultAndIgnoreTags
=== RUN   TestAccVPC_ignoreTags
=== PAUSE TestAccVPC_ignoreTags
=== RUN   TestAccVPC_tenancy
=== PAUSE TestAccVPC_tenancy
=== RUN   TestAccVPC_updateDNSHostnames
=== PAUSE TestAccVPC_updateDNSHostnames
=== RUN   TestAccVPC_bothDNSOptionsSet
=== PAUSE TestAccVPC_bothDNSOptionsSet
=== RUN   TestAccVPC_disabledDNSSupport
=== PAUSE TestAccVPC_disabledDNSSupport
=== RUN   TestAccVPC_classicLinkOptionSet
=== PAUSE TestAccVPC_classicLinkOptionSet
=== RUN   TestAccVPC_classicLinkDNSSupportOptionSet
=== PAUSE TestAccVPC_classicLinkDNSSupportOptionSet
=== RUN   TestAccVPC_assignGeneratedIPv6CIDRBlock
=== PAUSE TestAccVPC_assignGeneratedIPv6CIDRBlock
=== RUN   TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
=== PAUSE TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
=== RUN   TestAccVPC_IpamIpv4BasicNetmask
    vpc_test.go:877: skipping long-running test in short mode
--- SKIP: TestAccVPC_IpamIpv4BasicNetmask (0.00s)
=== RUN   TestAccVPC_IpamIpv4BasicExplicitCidr
    vpc_test.go:903: skipping long-running test in short mode
--- SKIP: TestAccVPC_IpamIpv4BasicExplicitCidr (0.00s)
=== CONT  TestAccVPC_basic
=== CONT  TestAccVPC_defaultAndIgnoreTags
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag
=== CONT  TestAccVPC_DynamicResourceTags_ignoreChanges
--- PASS: TestAccVPC_basic (27.99s)
=== CONT  TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges
--- PASS: TestAccVPC_DynamicResourceTags_ignoreChanges (41.42s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_duplicateTag
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_duplicateTag (1.13s)
=== CONT  TestAccVPC_DefaultTagsProviderAndResource_overlappingTag
--- PASS: TestAccVPC_defaultAndIgnoreTags (48.28s)
=== CONT  TestAccVPC_disabledDNSSupport
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_nonOverlappingTag (54.41s)
=== CONT  TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup
--- PASS: TestAccVPC_DynamicResourceTagsMergedWithLocals_ignoreChanges (40.97s)
=== CONT  TestAccVPC_assignGeneratedIPv6CIDRBlock
--- PASS: TestAccVPC_disabledDNSSupport (34.86s)
=== CONT  TestAccVPC_classicLinkDNSSupportOptionSet
--- PASS: TestAccVPC_DefaultTagsProviderAndResource_overlappingTag (53.50s)
=== CONT  TestAccVPC_classicLinkOptionSet
--- PASS: TestAccVPC_classicLinkDNSSupportOptionSet (25.61s)
=== CONT  TestAccVPC_DefaultTags_updateToResourceOnly
--- PASS: TestAccVPC_classicLinkOptionSet (27.00s)
=== CONT  TestAccVPC_DefaultTags_updateToProviderOnly
--- PASS: TestAccVPC_assignGeneratedIPv6CIDRBlockWithNetworkBorderGroup (85.01s)
=== CONT  TestAccVPC_updateDNSHostnames
--- PASS: TestAccVPC_DefaultTags_updateToResourceOnly (35.97s)
=== CONT  TestAccVPC_bothDNSOptionsSet
--- PASS: TestAccVPC_DefaultTags_updateToProviderOnly (34.88s)
=== CONT  TestAccVPC_tags
--- PASS: TestAccVPC_assignGeneratedIPv6CIDRBlock (96.08s)
=== CONT  TestAccVPC_tenancy
--- PASS: TestAccVPC_bothDNSOptionsSet (35.82s)
=== CONT  TestAccVPC_DefaultTags_providerOnly
--- PASS: TestAccVPC_updateDNSHostnames (50.80s)
=== CONT  TestAccVPC_disappears
--- PASS: TestAccVPC_disappears (14.51s)
=== CONT  TestAccVPC_ignoreTags
--- PASS: TestAccVPC_tags (64.68s)
--- PASS: TestAccVPC_tenancy (64.77s)
--- PASS: TestAccVPC_DefaultTags_providerOnly (52.47s)
--- PASS: TestAccVPC_ignoreTags (45.99s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	254.372s

GovCloud

% AWS_DEFAULT_REGION=us-gov-east-1 make testacc TESTS=TestAccEC2DefaultVPCAndSubnet_serial PKG=ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run='TestAccEC2DefaultVPCAndSubnet_serial'  -timeout 180m
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.forceDestroy
    default_vpc_test.go:61: Deleting existing default VPC: vpc-6c14f605
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.basic
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.assignGeneratedIPv6CIDRBlock
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.forceDestroy
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.basic
    default_vpc_test.go:61: Deleting existing default VPC: vpc-06068c88e4c7959ce
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.assignGeneratedIPv6CIDRBlock
    default_vpc_test.go:61: Deleting existing default VPC: vpc-0936215529ed21cbb
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.basic
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.forceDestroy
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.ipv6
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.privateDnsNameOptionsOnLaunch
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/notFound.basic
    default_subnet_test.go:62: Deleting existing default subnet: subnet-0f2f90846a9d0a0a9
    default_subnet_test.go:62: Deleting existing default subnet: subnet-09ad1c8218fa8761c
    default_subnet_test.go:62: Deleting existing default subnet: subnet-044958aed130233ed
=== RUN   TestAccEC2DefaultVPCAndSubnet_serial/Subnet/notFound.ipv6Native
    default_subnet_test.go:62: Deleting existing default subnet: subnet-06d7335e10eb99853
    default_subnet_test.go:62: Deleting existing default subnet: subnet-0e731aa6bb126a69f
    default_subnet_test.go:62: Deleting existing default subnet: subnet-0a3c0f4e27e8367b6
--- PASS: TestAccEC2DefaultVPCAndSubnet_serial (330.49s)
    --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC (134.91s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.forceDestroy (20.07s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.basic (13.70s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.assignGeneratedIPv6CIDRBlock (22.54s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/existing.forceDestroy (38.64s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.basic (14.83s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/VPC/notFound.assignGeneratedIPv6CIDRBlock (25.13s)
    --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet (195.58s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.basic (15.24s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.forceDestroy (11.74s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.ipv6 (67.87s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/existing.privateDnsNameOptionsOnLaunch (34.46s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/notFound.basic (16.11s)
        --- PASS: TestAccEC2DefaultVPCAndSubnet_serial/Subnet/notFound.ipv6Native (50.16s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	333.872s

ewbankkit · 2022-01-21T20:40:37Z

@dirk39 Thanks for the contribution 🎉 👏.

* version 4 upgrade guide WIP * Remove `aws_vpn_connection` sections. The implementation does not set `Default` values on attributes and is backwards compatible. * add instructions for breaking change introduced in #19198 * add instructions for breaking change introduced in #22043 * add instructions for breaking change introduced in #21771 * add instructions for breaking change introduced in #22253 Co-authored-by: Kit Ewbank <[email protected]>

github-actions · 2022-02-10T18:12:56Z

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

github-actions · 2022-05-20T02:32:47Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

justinretzolk added enhancement Requests to existing resources that expand the functionality or scope. and removed needs-triage Waiting for first response or review from a maintainer. labels Dec 16, 2021

anGie44 added this to the v4.0.0 milestone Jan 4, 2022

anGie44 added the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label Jan 4, 2022

ewbankkit and others added 21 commits January 12, 2022 13:41

r/aws_default_subnet: 'map_public_ip_on_launch' has a Default of true.

a56deb0

Additional 'modifySubnetAttriute' functions.

c7e39fc

'setting' -> 'modifying' in error messages.

83c730c

first draft

4709245

Signed-off-by: Andrea Quintino <[email protected]>

ok

d0e1a8d

Signed-off-by: Andrea Quintino <[email protected]>

test ok. manage destroy

b558e87

Signed-off-by: Andrea Quintino <[email protected]>

test ok. destroy ok

ea4a97e

Signed-off-by: Andrea Quintino <[email protected]>

test ok. destroy ok

c7c5086

Signed-off-by: Andrea Quintino <[email protected]>

updated doc

294ce62

Signed-off-by: dirk39 <[email protected]>

Revert "updated doc"

89da20c

This reverts commit 068311abc61af4ed43c841ffbce2b70690aec271.

Revert "test ok. destroy ok"

f5e87b6

This reverts commit 8d7b56c2e0058c52a14008d5ffdd8fdee46318c4.

Revert "test ok. destroy ok"

c5f180a

This reverts commit b415b4808674068c3631f21ae4e4170aeb85720c.

Revert "test ok. manage destroy"

94480a5

This reverts commit 972ff5e0e36be04287a5091bd2d5c58c87564618.

Revert "ok"

76ded69

This reverts commit d74c36cdc05338b62c02df5244661e38ade6b4ab.

Revert "first draft"

3bd4f02

This reverts commit 484f2921324b8fb202f396a8ac99d85bafa6d429.

Merge remote-tracking branch 'origin/f-aws_default_subnet-full-lifecy…

77dd449

…cle' into HEAD

ewbankkit added 2 commits January 20, 2022 12:25

EC2: 'testCheckResourceAttrGreaterThanValue' -> 'acctest.CheckResourc…

2b20775

…eAttrGreaterThanValue'.

EKS: 'testCheckResourceAttrGreaterThanValue' -> 'acctest.CheckResourc…

dc19d47

…eAttrGreaterThanValue'.

github-actions bot added the service/eks Issues and PRs that pertain to the eks service. label Jan 20, 2022

ewbankkit added 4 commits January 20, 2022 14:09

anGie44 force-pushed the release/4.x branch 3 times, most recently from 1e894e8 to 6623846 Compare January 21, 2022 16:39

ewbankkit changed the title ~~[WIP] aws_default_vpc and aws_default_subnet: Full lifecycle~~ aws_default_vpc and aws_default_subnet: Full lifecycle Jan 21, 2022

ewbankkit approved these changes Jan 21, 2022

View reviewed changes

Documentation updates.

d79cf7e

github-actions bot added the documentation Introduces or discusses updates to documentation. label Jan 21, 2022

ewbankkit merged commit ffeacc8 into hashicorp:release/4.x Jan 21, 2022

anGie44 added a commit that referenced this pull request Feb 2, 2022

add instructions for breaking change introduced in #22253

430eff1

github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

`aws_default_vpc` and `aws_default_subnet`: Full lifecycle #22253

`aws_default_vpc` and `aws_default_subnet`: Full lifecycle #22253

dirk39 commented Dec 16, 2021 •

edited by ewbankkit

Loading

ewbankkit left a comment

ewbankkit commented Jan 21, 2022

github-actions bot commented Feb 10, 2022

github-actions bot commented May 20, 2022

aws_default_vpc and aws_default_subnet: Full lifecycle #22253

aws_default_vpc and aws_default_subnet: Full lifecycle #22253

Conversation

dirk39 commented Dec 16, 2021 • edited by ewbankkit Loading

Community Note

ewbankkit left a comment

Choose a reason for hiding this comment

Commercial

GovCloud

ewbankkit commented Jan 21, 2022

github-actions bot commented Feb 10, 2022

github-actions bot commented May 20, 2022

`aws_default_vpc` and `aws_default_subnet`: Full lifecycle #22253

`aws_default_vpc` and `aws_default_subnet`: Full lifecycle #22253

dirk39 commented Dec 16, 2021 •

edited by ewbankkit

Loading