Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Aws elasticache global replication group: Remove deprecated parameter actual_engine_version #19198

Merged
merged 10 commits into from
Jan 28, 2022
Merged

Aws elasticache global replication group: Remove deprecated parameter actual_engine_version #19198

merged 10 commits into from
Jan 28, 2022

Conversation

nikhil-goenka
Copy link
Contributor

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Relates OR Closes #18924

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSElasticacheGlobalReplicationGroup_basic'
--- PASS: TestAccAWSElasticacheGlobalReplicationGroup_basic (1101.71s)
...

@nikhil-goenka nikhil-goenka requested a review from a team as a code owner May 2, 2021 10:31
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels May 2, 2021
@github-actions github-actions bot added the needs-triage Waiting for first response or review from a maintainer. label May 2, 2021
@gdavison gdavison added breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. and removed needs-triage Waiting for first response or review from a maintainer. labels May 5, 2021
@gdavison gdavison added this to the v4.0.0 milestone May 5, 2021
@zhelding
Copy link
Contributor

Pull request #21306 has significantly refactored the AWS Provider codebase. As a result, most PRs opened prior to the refactor now have merge conflicts that must be resolved before proceeding.

Specifically, PR #21306 relocated the code for all AWS resources and data sources from a single aws directory to a large number of separate directories in internal/service, each corresponding to a particular AWS service. This separation of code has also allowed for us to simplify the names of underlying functions -- while still avoiding namespace collisions.

We recognize that many pull requests have been open for some time without yet being addressed by our maintainers. Therefore, we want to make it clear that resolving these conflicts in no way affects the prioritization of a particular pull request. Once a pull request has been prioritized for review, the necessary changes will be made by a maintainer -- either directly or in collaboration with the pull request author.

For a more complete description of this refactor, including examples of how old filepaths and function names correspond to their new counterparts: please refer to issue #20000.

For a quick guide on how to amend your pull request to resolve the merge conflicts resulting from this refactor and bring it in line with our new code patterns: please refer to our Service Package Refactor Pull Request Guide.

@anGie44 anGie44 assigned anGie44 and YakDriver and unassigned anGie44 Jan 26, 2022
@YakDriver YakDriver changed the base branch from main to release/4.x January 28, 2022 19:06
@YakDriver YakDriver merged this pull request into hashicorp:release/4.x Jan 28, 2022
anGie44 added a commit that referenced this pull request Feb 2, 2022
@anGie44
add instructions for breaking change introduced in #19198
0af25b7
anGie44 added a commit that referenced this pull request Feb 2, 2022
@anGie44 @ewbankkit
Version 4 Upgrade Guide Base (#22818)
43984d3 
* version 4 upgrade guide WIP

* Remove `aws_vpn_connection` sections.

The implementation does not set `Default` values on attributes and is backwards compatible.

* add instructions for breaking change introduced in #19198

* add instructions for breaking change introduced in #22043

* add instructions for breaking change introduced in #21771

* add instructions for breaking change introduced in #22253

Co-authored-by: Kit Ewbank <[email protected]>
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@YakDriver YakDriver

Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. service/elasticache Issues and PRs that pertain to the elasticache service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

resource/aws_elasticache_global_replication_group: Remove deprecated parameter actual_engine_version
5 participants
@nikhil-goenka @zhelding @gdavison @anGie44 @YakDriver