Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed instance_interruption_behaviour field from spot_instance_request #21771

Merged
merged 0 commits into from
Jan 26, 2022
Merged

Removed instance_interruption_behaviour field from spot_instance_request #21771

merged 0 commits into from
Jan 26, 2022

Conversation

dirk39
Copy link
Contributor

@dirk39 dirk39 commented Nov 14, 2021 •
edited by anGie44
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #16191

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccEC2SpotInstanceRequest*' PKG_NAME=internal/service/ec2 

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2SpotInstanceRequest* -timeout 180m
=== RUN   TestAccEC2SpotInstanceRequest_basic
=== PAUSE TestAccEC2SpotInstanceRequest_basic
=== RUN   TestAccEC2SpotInstanceRequest_tags
=== PAUSE TestAccEC2SpotInstanceRequest_tags
=== RUN   TestAccEC2SpotInstanceRequest_keyName
=== PAUSE TestAccEC2SpotInstanceRequest_keyName
=== RUN   TestAccEC2SpotInstanceRequest_withLaunchGroup
=== PAUSE TestAccEC2SpotInstanceRequest_withLaunchGroup
=== RUN   TestAccEC2SpotInstanceRequest_withBlockDuration
=== PAUSE TestAccEC2SpotInstanceRequest_withBlockDuration
=== RUN   TestAccEC2SpotInstanceRequest_vpc
=== PAUSE TestAccEC2SpotInstanceRequest_vpc
=== RUN   TestAccEC2SpotInstanceRequest_validUntil
=== PAUSE TestAccEC2SpotInstanceRequest_validUntil
=== RUN   TestAccEC2SpotInstanceRequest_withoutSpotPrice
=== PAUSE TestAccEC2SpotInstanceRequest_withoutSpotPrice
=== RUN   TestAccEC2SpotInstanceRequest_subnetAndSGAndPublicIPAddress
=== PAUSE TestAccEC2SpotInstanceRequest_subnetAndSGAndPublicIPAddress
=== RUN   TestAccEC2SpotInstanceRequest_networkInterfaceAttributes
=== PAUSE TestAccEC2SpotInstanceRequest_networkInterfaceAttributes
=== RUN   TestAccEC2SpotInstanceRequest_getPasswordData
=== PAUSE TestAccEC2SpotInstanceRequest_getPasswordData
=== RUN   TestAccEC2SpotInstanceRequest_disappears
=== PAUSE TestAccEC2SpotInstanceRequest_disappears
=== RUN   TestAccEC2SpotInstanceRequest_interruptStop
=== PAUSE TestAccEC2SpotInstanceRequest_interruptStop
=== RUN   TestAccEC2SpotInstanceRequest_interruptHibernate
=== PAUSE TestAccEC2SpotInstanceRequest_interruptHibernate
=== RUN   TestAccEC2SpotInstanceRequest_interruptUpdate
=== PAUSE TestAccEC2SpotInstanceRequest_interruptUpdate
=== CONT  TestAccEC2SpotInstanceRequest_basic
=== CONT  TestAccEC2SpotInstanceRequest_subnetAndSGAndPublicIPAddress
=== CONT  TestAccEC2SpotInstanceRequest_withBlockDuration
=== CONT  TestAccEC2SpotInstanceRequest_disappears
=== CONT  TestAccEC2SpotInstanceRequest_withLaunchGroup
=== CONT  TestAccEC2SpotInstanceRequest_tags
=== CONT  TestAccEC2SpotInstanceRequest_vpc
=== CONT  TestAccEC2SpotInstanceRequest_getPasswordData
=== CONT  TestAccEC2SpotInstanceRequest_interruptHibernate
=== CONT  TestAccEC2SpotInstanceRequest_keyName
=== CONT  TestAccEC2SpotInstanceRequest_interruptStop
=== CONT  TestAccEC2SpotInstanceRequest_networkInterfaceAttributes
=== CONT  TestAccEC2SpotInstanceRequest_interruptUpdate
=== CONT  TestAccEC2SpotInstanceRequest_validUntil
=== CONT  TestAccEC2SpotInstanceRequest_withoutSpotPrice
=== CONT  TestAccEC2SpotInstanceRequest_withBlockDuration
    spot_instance_request_test.go:166: Step 1/2 error: Error running apply: exit status 1
        
        Error: Error requesting spot instances: InvalidParameterValue: BlockDurationMinutes is not a valid parameter.
        	status code: 400, request id: 1c2f32df-81fa-4151-9cbe-6444a78b3130
        
          on terraform_plugin_test.tf line 26, in resource "aws_spot_instance_request" "test":
          26: resource "aws_spot_instance_request" "test" {
        
        
--- FAIL: TestAccEC2SpotInstanceRequest_withBlockDuration (27.11s)
--- PASS: TestAccEC2SpotInstanceRequest_validUntil (90.97s)
--- PASS: TestAccEC2SpotInstanceRequest_withoutSpotPrice (90.99s)
--- PASS: TestAccEC2SpotInstanceRequest_withLaunchGroup (114.13s)
--- PASS: TestAccEC2SpotInstanceRequest_basic (124.58s)
--- PASS: TestAccEC2SpotInstanceRequest_vpc (125.29s)
--- PASS: TestAccEC2SpotInstanceRequest_subnetAndSGAndPublicIPAddress (139.63s)
--- PASS: TestAccEC2SpotInstanceRequest_interruptStop (143.91s)
--- PASS: TestAccEC2SpotInstanceRequest_interruptHibernate (143.94s)
--- PASS: TestAccEC2SpotInstanceRequest_keyName (144.49s)
--- PASS: TestAccEC2SpotInstanceRequest_networkInterfaceAttributes (154.11s)
--- PASS: TestAccEC2SpotInstanceRequest_getPasswordData (177.33s)
--- PASS: TestAccEC2SpotInstanceRequest_tags (215.63s)
--- PASS: TestAccEC2SpotInstanceRequest_disappears (371.15s)
--- PASS: TestAccEC2SpotInstanceRequest_interruptUpdate (442.12s)
FAIL
FAIL	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	442.227s
FAIL

The only test that failed is the TestAccEC2SpotInstanceRequest_withBlockDuration because the support of the field block_duration_minutes has been removed

@github-actions github-actions bot added needs-triage Waiting for first response or review from a maintainer. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. size/L Managed by automation to categorize the size of a PR. labels Nov 14, 2021
@ewbankkit ewbankkit added this to the v4.0.0 milestone Nov 15, 2021
@ewbankkit ewbankkit removed the needs-triage Waiting for first response or review from a maintainer. label Nov 15, 2021
ewbankkit
ewbankkit approved these changes Nov 15, 2021
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccEC2SpotInstanceRequest*' PKG_NAME=internal/service/ec2
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/ec2/... -v -count 1 -parallel 20 -run=TestAccEC2SpotInstanceRequest* -timeout 180m
=== RUN   TestAccEC2SpotInstanceRequest_basic
=== PAUSE TestAccEC2SpotInstanceRequest_basic
=== RUN   TestAccEC2SpotInstanceRequest_tags
=== PAUSE TestAccEC2SpotInstanceRequest_tags
=== RUN   TestAccEC2SpotInstanceRequest_keyName
=== PAUSE TestAccEC2SpotInstanceRequest_keyName
=== RUN   TestAccEC2SpotInstanceRequest_withLaunchGroup
=== PAUSE TestAccEC2SpotInstanceRequest_withLaunchGroup
=== RUN   TestAccEC2SpotInstanceRequest_withBlockDuration
=== PAUSE TestAccEC2SpotInstanceRequest_withBlockDuration
=== RUN   TestAccEC2SpotInstanceRequest_vpc
=== PAUSE TestAccEC2SpotInstanceRequest_vpc
=== RUN   TestAccEC2SpotInstanceRequest_validUntil
=== PAUSE TestAccEC2SpotInstanceRequest_validUntil
=== RUN   TestAccEC2SpotInstanceRequest_withoutSpotPrice
=== PAUSE TestAccEC2SpotInstanceRequest_withoutSpotPrice
=== RUN   TestAccEC2SpotInstanceRequest_subnetAndSGAndPublicIPAddress
=== PAUSE TestAccEC2SpotInstanceRequest_subnetAndSGAndPublicIPAddress
=== RUN   TestAccEC2SpotInstanceRequest_networkInterfaceAttributes
=== PAUSE TestAccEC2SpotInstanceRequest_networkInterfaceAttributes
=== RUN   TestAccEC2SpotInstanceRequest_getPasswordData
=== PAUSE TestAccEC2SpotInstanceRequest_getPasswordData
=== RUN   TestAccEC2SpotInstanceRequest_disappears
=== PAUSE TestAccEC2SpotInstanceRequest_disappears
=== RUN   TestAccEC2SpotInstanceRequest_interruptStop
=== PAUSE TestAccEC2SpotInstanceRequest_interruptStop
=== RUN   TestAccEC2SpotInstanceRequest_interruptHibernate
=== PAUSE TestAccEC2SpotInstanceRequest_interruptHibernate
=== RUN   TestAccEC2SpotInstanceRequest_interruptUpdate
=== PAUSE TestAccEC2SpotInstanceRequest_interruptUpdate
=== CONT  TestAccEC2SpotInstanceRequest_basic
=== CONT  TestAccEC2SpotInstanceRequest_subnetAndSGAndPublicIPAddress
=== CONT  TestAccEC2SpotInstanceRequest_networkInterfaceAttributes
=== CONT  TestAccEC2SpotInstanceRequest_withBlockDuration
=== CONT  TestAccEC2SpotInstanceRequest_withoutSpotPrice
=== CONT  TestAccEC2SpotInstanceRequest_validUntil
=== CONT  TestAccEC2SpotInstanceRequest_vpc
=== CONT  TestAccEC2SpotInstanceRequest_keyName
=== CONT  TestAccEC2SpotInstanceRequest_withLaunchGroup
=== CONT  TestAccEC2SpotInstanceRequest_tags
=== CONT  TestAccEC2SpotInstanceRequest_interruptStop
=== CONT  TestAccEC2SpotInstanceRequest_interruptUpdate
=== CONT  TestAccEC2SpotInstanceRequest_getPasswordData
=== CONT  TestAccEC2SpotInstanceRequest_interruptHibernate
=== CONT  TestAccEC2SpotInstanceRequest_disappears
--- PASS: TestAccEC2SpotInstanceRequest_withLaunchGroup (98.68s)
--- PASS: TestAccEC2SpotInstanceRequest_basic (99.91s)
--- PASS: TestAccEC2SpotInstanceRequest_validUntil (128.13s)
--- PASS: TestAccEC2SpotInstanceRequest_interruptHibernate (131.11s)
--- PASS: TestAccEC2SpotInstanceRequest_interruptStop (131.43s)
--- PASS: TestAccEC2SpotInstanceRequest_withoutSpotPrice (138.00s)
--- PASS: TestAccEC2SpotInstanceRequest_withBlockDuration (141.16s)
--- PASS: TestAccEC2SpotInstanceRequest_keyName (141.99s)
--- PASS: TestAccEC2SpotInstanceRequest_vpc (157.50s)
--- PASS: TestAccEC2SpotInstanceRequest_subnetAndSGAndPublicIPAddress (162.85s)
--- PASS: TestAccEC2SpotInstanceRequest_networkInterfaceAttributes (173.85s)
--- PASS: TestAccEC2SpotInstanceRequest_getPasswordData (181.20s)
--- PASS: TestAccEC2SpotInstanceRequest_tags (202.49s)
--- PASS: TestAccEC2SpotInstanceRequest_interruptUpdate (224.87s)
--- PASS: TestAccEC2SpotInstanceRequest_disappears (354.97s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/ec2	361.463s

@ewbankkit
Copy link
Contributor

@dirk39 Thanks for the contribution 🎉 👏.

We'll merge this as part of v4.0.0, hopefully at the start of the new year.

@dirk39
Copy link
Contributor Author

dirk39 commented Nov 16, 2021

It will solve also #16191

@anGie44 anGie44 changed the title Removed instance_interruption_behaviour field from spot_instance_request Removed instance_interruption_behaviour field from spot_instance_request Jan 11, 2022
@anGie44 anGie44 changed the base branch from main to release/4.x January 26, 2022 16:46
@anGie44 anGie44 merged this pull request into hashicorp:release/4.x Jan 26, 2022
@anGie44 anGie44 mentioned this pull request Jan 26, 2022
Closed
@anGie44 anGie44 added the breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. label Feb 2, 2022
anGie44 added a commit that referenced this pull request Feb 2, 2022
@anGie44
add instructions for breaking change introduced in #21771
6c2e144
anGie44 added a commit that referenced this pull request Feb 2, 2022
@anGie44 @ewbankkit
Version 4 Upgrade Guide Base (#22818)
43984d3 
* version 4 upgrade guide WIP

* Remove `aws_vpn_connection` sections.

The implementation does not set `Default` values on attributes and is backwards compatible.

* add instructions for breaking change introduced in #19198

* add instructions for breaking change introduced in #22043

* add instructions for breaking change introduced in #21771

* add instructions for breaking change introduced in #22253

Co-authored-by: Kit Ewbank <[email protected]>
@github-actions
Copy link

This functionality has been released in v4.0.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

Assignees
No one assigned
Labels
breaking-change Introduces a breaking change in current functionality; usually deferred to the next major release. documentation Introduces or discusses updates to documentation. service/ec2 Issues and PRs that pertain to the ec2 service. size/L Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

resource/aws_spot_instance_request: remove instance_interruption_behaviour
3 participants
@dirk39 @ewbankkit @anGie44