Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

r/sagemaker_endpoint_configuration - support data_capture_config + validations and test refactor #15887

Merged
merged 17 commits into from
Nov 5, 2020
Merged

r/sagemaker_endpoint_configuration - support data_capture_config + validations and test refactor #15887

merged 17 commits into from
Nov 5, 2020

Conversation

DrFaust92
Copy link
Collaborator

@DrFaust92 DrFaust92 commented Oct 28, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Supersedes #11484
Closes #14170
Relates #13826

Release note for CHANGELOG:

resource_aws_sagemaker_endpoint_configuration -  support `data_capture_config`
resource_aws_sagemaker_endpoint_configuration -  add plan time validation for `production_variants.accelerator_type`, `production_variants.instance_type `

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSSagemakerEndpointConfiguration_'
--- PASS: TestAccAWSSagemakerEndpointConfiguration_kmsKeyId (65.41s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_disappears (67.85s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_basic (68.95s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_dataCaptureConfig (80.93s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_productionVariants_InitialVariantWeight (84.77s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_productionVariants_AcceleratorType (86.74s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_tags (140.43s)

@DrFaust92 DrFaust92 requested a review from a team October 28, 2020 16:08
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/sagemaker Issues and PRs that pertain to the sagemaker service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 28, 2020
@DrFaust92 DrFaust92 added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 28, 2020
ewbankkit
ewbankkit approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSagemakerEndpointConfiguration_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerEndpointConfiguration_ -timeout 120m
=== RUN   TestAccAWSSagemakerEndpointConfiguration_basic
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_basic
=== RUN   TestAccAWSSagemakerEndpointConfiguration_productionVariants_InitialVariantWeight
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_productionVariants_InitialVariantWeight
=== RUN   TestAccAWSSagemakerEndpointConfiguration_productionVariants_AcceleratorType
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_productionVariants_AcceleratorType
=== RUN   TestAccAWSSagemakerEndpointConfiguration_kmsKeyId
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_kmsKeyId
=== RUN   TestAccAWSSagemakerEndpointConfiguration_tags
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_tags
=== RUN   TestAccAWSSagemakerEndpointConfiguration_dataCaptureConfig
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_dataCaptureConfig
=== RUN   TestAccAWSSagemakerEndpointConfiguration_disappears
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_disappears
=== CONT  TestAccAWSSagemakerEndpointConfiguration_basic
=== CONT  TestAccAWSSagemakerEndpointConfiguration_tags
=== CONT  TestAccAWSSagemakerEndpointConfiguration_disappears
=== CONT  TestAccAWSSagemakerEndpointConfiguration_dataCaptureConfig
=== CONT  TestAccAWSSagemakerEndpointConfiguration_productionVariants_AcceleratorType
=== CONT  TestAccAWSSagemakerEndpointConfiguration_kmsKeyId
=== CONT  TestAccAWSSagemakerEndpointConfiguration_productionVariants_InitialVariantWeight
--- PASS: TestAccAWSSagemakerEndpointConfiguration_productionVariants_AcceleratorType (50.42s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_disappears (58.39s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_basic (60.73s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_productionVariants_InitialVariantWeight (62.53s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_kmsKeyId (65.66s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_dataCaptureConfig (70.63s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_tags (85.68s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	85.739s

@DrFaust92 DrFaust92 force-pushed the r/sagemaker_endpoint_configuration_data_capture branch from da3661f to b57cbae Compare October 30, 2020 07:21
@DrFaust92
Copy link
Collaborator Author

Thanks @YakDriver, added changes and tested :

--- PASS: TestAccAWSSagemakerEndpointConfiguration_disappears (72.06s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_kmsKeyId (74.59s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_productionVariants_InitialVariantWeight (77.22s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_basic (80.55s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_productionVariants_AcceleratorType (82.60s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_dataCaptureConfig (101.76s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_tags (155.19s)

@YakDriver
Copy link
Member

If we can hold off on this until #15924 is merged, this PR can use that.

@DrFaust92 DrFaust92 force-pushed the r/sagemaker_endpoint_configuration_data_capture branch from b57cbae to f3c7f50 Compare October 31, 2020 16:41
@DrFaust92
Copy link
Collaborator Author

@YakDriver, using the new datasource. tests are passing

@ewbankkit
Copy link
Contributor

Verified acceptance test in default and non-default Commercial regions:

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSagemakerEndpointConfiguration_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerEndpointConfiguration_ -timeout 120m
=== RUN   TestAccAWSSagemakerEndpointConfiguration_basic
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_basic
=== RUN   TestAccAWSSagemakerEndpointConfiguration_productionVariants_InitialVariantWeight
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_productionVariants_InitialVariantWeight
=== RUN   TestAccAWSSagemakerEndpointConfiguration_productionVariants_AcceleratorType
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_productionVariants_AcceleratorType
=== RUN   TestAccAWSSagemakerEndpointConfiguration_kmsKeyId
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_kmsKeyId
=== RUN   TestAccAWSSagemakerEndpointConfiguration_tags
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_tags
=== RUN   TestAccAWSSagemakerEndpointConfiguration_dataCaptureConfig
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_dataCaptureConfig
=== RUN   TestAccAWSSagemakerEndpointConfiguration_disappears
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_disappears
=== CONT  TestAccAWSSagemakerEndpointConfiguration_basic
=== CONT  TestAccAWSSagemakerEndpointConfiguration_tags
=== CONT  TestAccAWSSagemakerEndpointConfiguration_disappears
=== CONT  TestAccAWSSagemakerEndpointConfiguration_dataCaptureConfig
=== CONT  TestAccAWSSagemakerEndpointConfiguration_productionVariants_AcceleratorType
=== CONT  TestAccAWSSagemakerEndpointConfiguration_kmsKeyId
=== CONT  TestAccAWSSagemakerEndpointConfiguration_productionVariants_InitialVariantWeight
--- PASS: TestAccAWSSagemakerEndpointConfiguration_productionVariants_AcceleratorType (52.42s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_productionVariants_InitialVariantWeight (55.05s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_disappears (55.51s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_dataCaptureConfig (57.98s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_basic (62.66s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_kmsKeyId (68.31s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_tags (85.88s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	85.945s
$ AWS_DEFAULT_REGION=us-east-2 make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSagemakerEndpointConfiguration_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerEndpointConfiguration_ -timeout 120m
=== RUN   TestAccAWSSagemakerEndpointConfiguration_basic
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_basic
=== RUN   TestAccAWSSagemakerEndpointConfiguration_productionVariants_InitialVariantWeight
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_productionVariants_InitialVariantWeight
=== RUN   TestAccAWSSagemakerEndpointConfiguration_productionVariants_AcceleratorType
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_productionVariants_AcceleratorType
=== RUN   TestAccAWSSagemakerEndpointConfiguration_kmsKeyId
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_kmsKeyId
=== RUN   TestAccAWSSagemakerEndpointConfiguration_tags
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_tags
=== RUN   TestAccAWSSagemakerEndpointConfiguration_dataCaptureConfig
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_dataCaptureConfig
=== RUN   TestAccAWSSagemakerEndpointConfiguration_disappears
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_disappears
=== CONT  TestAccAWSSagemakerEndpointConfiguration_basic
=== CONT  TestAccAWSSagemakerEndpointConfiguration_tags
=== CONT  TestAccAWSSagemakerEndpointConfiguration_disappears
=== CONT  TestAccAWSSagemakerEndpointConfiguration_kmsKeyId
=== CONT  TestAccAWSSagemakerEndpointConfiguration_dataCaptureConfig
=== CONT  TestAccAWSSagemakerEndpointConfiguration_productionVariants_AcceleratorType
=== CONT  TestAccAWSSagemakerEndpointConfiguration_productionVariants_InitialVariantWeight
--- PASS: TestAccAWSSagemakerEndpointConfiguration_basic (35.44s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_productionVariants_InitialVariantWeight (40.34s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_dataCaptureConfig (45.77s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_disappears (52.71s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_productionVariants_AcceleratorType (53.40s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_kmsKeyId (57.36s)
--- PASS: TestAccAWSSagemakerEndpointConfiguration_tags (77.98s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	78.041s

@breathingdust breathingdust mentioned this pull request Nov 5, 2020
Closed
YakDriver
YakDriver approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@YakDriver YakDriver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I say we forge ahead and tackle the next level of GovCloud problems in subsequent PR(s).

@YakDriver YakDriver mentioned this pull request Nov 5, 2020
Closed
11 tasks
@YakDriver YakDriver merged commit 290d97d into hashicorp:master Nov 5, 2020
@YakDriver YakDriver added this to the v3.14.0 milestone Nov 5, 2020
@ghost
Copy link

ghost commented Nov 6, 2020

This has been released in version 3.14.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Dec 6, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Dec 6, 2020
@DrFaust92 DrFaust92 deleted the r/sagemaker_endpoint_configuration_data_capture branch April 15, 2021 10:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@breathingdust breathingdust breathingdust left review comments

@ewbankkit ewbankkit ewbankkit approved these changes

@YakDriver YakDriver YakDriver approved these changes

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.14.0
Development

Successfully merging this pull request may close these issues.

Sagemaker capture data feature
5 participants
@DrFaust92 @YakDriver @ewbankkit @breathingdust @SaiKiranBurle