Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ds/sagemaker_prebuilt_ecr_image: New data source #15924

Merged
merged 1 commit into from
Oct 30, 2020
Merged

ds/sagemaker_prebuilt_ecr_image: New data source #15924

merged 1 commit into from
Oct 30, 2020
+459 −0

Conversation

YakDriver
Copy link
Member

@YakDriver YakDriver commented Oct 30, 2020 •
edited
Loading

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #15940

Release note for CHANGELOG:

New Data Source: aws_sagemaker_prebuilt_ecr_image (#15924)

Output from acceptance testing (GovCloud):

--- PASS: TestAccAWSSageMakerPrebuiltECRImage_basic (15.93s)
--- PASS: TestAccAWSSageMakerPrebuiltECRImage_region (16.12s)

Output from acceptance testing (commercial):

--- PASS: TestAccAWSSageMakerPrebuiltECRImage_region (10.59s)
--- PASS: TestAccAWSSageMakerPrebuiltECRImage_basic (10.60s)

@ghost ghost added size/L Managed by automation to categorize the size of a PR. service/sagemaker Issues and PRs that pertain to the sagemaker service. labels Oct 30, 2020
@YakDriver YakDriver force-pushed the f-ds-sagemaker-prebuilt branch 4 times, most recently from 7f9d470 to 569d2f1 Compare October 30, 2020 15:21
@ghost ghost added size/XL Managed by automation to categorize the size of a PR. and removed size/L Managed by automation to categorize the size of a PR. labels Oct 30, 2020
@ghost ghost added provider Pertains to the provider itself, rather than any interaction with AWS. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Oct 30, 2020
@ghost ghost added the documentation Introduces or discusses updates to documentation. label Oct 30, 2020
@YakDriver YakDriver changed the title ds/sagemaker_prebuilt_image_path: New data source ds/sagemaker_prebuilt_image: New data source Oct 30, 2020
@YakDriver YakDriver marked this pull request as ready for review October 30, 2020 17:22
@YakDriver YakDriver requested a review from a team October 30, 2020 17:22
@YakDriver YakDriver mentioned this pull request Oct 30, 2020
Closed
@YakDriver YakDriver changed the title ds/sagemaker_prebuilt_image: New data source ds/sagemaker_prebuilt_ecr_image: New data source Oct 30, 2020
@ghost ghost added the service/ecr Issues and PRs that pertain to the ecr service. label Oct 30, 2020
@YakDriver YakDriver mentioned this pull request Oct 30, 2020
Merged
ewbankkit
ewbankkit approved these changes Oct 30, 2020
View reviewed changes
Copy link
Contributor

@ewbankkit ewbankkit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

$ make testacc TEST=./aws/ TESTARGS='-run=TestAccAWSSageMakerPrebuiltECRImage_'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSageMakerPrebuiltECRImage_ -timeout 120m
=== RUN   TestAccAWSSageMakerPrebuiltECRImage_basic
=== PAUSE TestAccAWSSageMakerPrebuiltECRImage_basic
=== RUN   TestAccAWSSageMakerPrebuiltECRImage_region
=== PAUSE TestAccAWSSageMakerPrebuiltECRImage_region
=== CONT  TestAccAWSSageMakerPrebuiltECRImage_basic
=== CONT  TestAccAWSSageMakerPrebuiltECRImage_region
--- PASS: TestAccAWSSageMakerPrebuiltECRImage_basic (14.28s)
--- PASS: TestAccAWSSageMakerPrebuiltECRImage_region (14.28s)
PASS
ok  	github.com/terraform-providers/terraform-provider-aws/aws	14.341s

@YakDriver YakDriver added this to the v3.14.0 milestone Oct 30, 2020
@YakDriver YakDriver merged commit 9f4423f into master Oct 30, 2020
@YakDriver YakDriver deleted the f-ds-sagemaker-prebuilt branch October 30, 2020 20:03
@YakDriver YakDriver mentioned this pull request Nov 5, 2020
Closed
11 tasks
@ghost
Copy link

ghost commented Nov 6, 2020

This has been released in version 3.14.0 of the Terraform AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template for triage. Thanks!

@ghost
Copy link

ghost commented Nov 30, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked as resolved and limited conversation to collaborators Nov 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ewbankkit ewbankkit ewbankkit approved these changes

@DrFaust92 DrFaust92 Awaiting requested review from DrFaust92

Assignees
No one assigned
Labels
documentation Introduces or discusses updates to documentation. provider Pertains to the provider itself, rather than any interaction with AWS. service/ecr Issues and PRs that pertain to the ecr service. service/sagemaker Issues and PRs that pertain to the sagemaker service. size/XL Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Milestone
v3.14.0
Development

Successfully merging this pull request may close these issues.

Need SageMaker data source for registry IDs, paths for prebuilt Docker images
2 participants
@YakDriver @ewbankkit