Add data capture config to Sagemaker endpoint configuration #11484

SaiKiranBurle · 2020-01-06T03:06:33Z

Community Note

Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Release note for CHANGELOG:

resource/aws_sagemaker_endpoint_configuration: Add `data_capture_config` argument.

Output from acceptance testing:

$ make testacc TEST=./aws TESTARGS='-run=TestAccAWSSagemakerEndpointConfiguration_DataCaptureConfig'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./aws -v -count 1 -parallel 20 -run=TestAccAWSSagemakerEndpointConfiguration_DataCaptureConfig -timeout 120m
=== RUN   TestAccAWSSagemakerEndpointConfiguration_DataCaptureConfig
=== PAUSE TestAccAWSSagemakerEndpointConfiguration_DataCaptureConfig
=== CONT  TestAccAWSSagemakerEndpointConfiguration_DataCaptureConfig
--- PASS: TestAccAWSSagemakerEndpointConfiguration_DataCaptureConfig (38.70s)
PASS
ok      github.com/terraform-providers/terraform-provider-aws/aws       38.749s

SaiKiranBurle · 2020-01-10T00:31:15Z

Just wondering what else needs to be done to get this merged.

DrFaust92

Hey, looks good! some comments on styling and simplifying handling of slices/lists

DrFaust92 · 2020-08-23T19:31:39Z

aws/resource_aws_sagemaker_endpoint_configuration.go

+										Type:         schema.TypeString,
+										Required:     true,
+										ForceNew:     true,
+										ValidateFunc: validation.StringInSlice([]string{"Input", "Output"}, false),


lets change this to:
ValidateFunc: validation.StringInSlice(sagemaker.CaptureMode_Values(), false),

DrFaust92 · 2020-08-23T19:32:16Z

aws/resource_aws_sagemaker_endpoint_configuration.go

+	}
+
+	cfg := map[string]interface{}{
+		//"enable_capture":              aws.BoolValue(dataCaptureConfig.EnableCapture),


let remove commented out code 😺

DrFaust92 · 2020-08-23T19:38:44Z

aws/resource_aws_sagemaker_endpoint_configuration.go

+							Elem: &schema.Resource{
+								Schema: map[string]*schema.Schema{
+									"csv_content_types": {
+										Type:     schema.TypeList,


I think we can similify this to look like this:

"csv_content_types": { Type: schema.TypeSet, MinItems: 1, MaxItems: 10, Elem: &schema.Schema{ Type: schema.TypeString, ValidateFunc: validateSagemakerCsvContentType, }, Optional: true, ForceNew: true, },

this will also look more similar to the API as it corresponds to slices CsvContentTypes []*string

DrFaust92 · 2020-08-23T19:40:26Z

aws/resource_aws_sagemaker_endpoint_configuration.go

+										ForceNew: true,
+									},
+
+									"json_content_types": {


same as above

DrFaust92 · 2020-08-23T19:41:32Z

aws/resource_aws_sagemaker_endpoint_configuration.go

+	if v, ok := m["csv_content_types"]; ok && len(v.([]interface{})) > 0 {
+		contentTypes := make([]*string, 0, len(v.([]interface{})))
+
+		for _, raw := range v.([]interface{}) {
+			sRaw := raw.(map[string]interface{})["content_type"]
+			contentTypes = append(contentTypes, aws.String(sRaw.(string)))
+		}
+
+		c.CsvContentTypes = contentTypes
+	}


if the above changes to type are made this can be reduced to:

c.CsvContentTypes = expandStringSet(v.(*Schema.Set))

DrFaust92 · 2020-08-23T19:41:38Z

aws/resource_aws_sagemaker_endpoint_configuration.go

+		c.CsvContentTypes = contentTypes
+	}
+
+	if v, ok := m["json_content_types"]; ok && len(v.([]interface{})) > 0 {


same as above

DrFaust92 · 2020-08-23T19:42:34Z

aws/resource_aws_sagemaker_endpoint_configuration.go

+	if contentTypeHeader.CsvContentTypes != nil {
+		csvTypes := make([]map[string]interface{}, 0, len(contentTypeHeader.CsvContentTypes))
+
+		for _, csvType := range contentTypeHeader.CsvContentTypes {
+			m := map[string]interface{}{
+				"content_type": aws.StringValue(csvType),
+			}
+			csvTypes = append(csvTypes, m)
+		}
+
+		l["csv_content_types"] = csvTypes
+	}


again as above, this will reduced to:

l["csv_content_types"] = flattenStringSet(contentTypeHeader.CsvContentTypes)

DrFaust92 · 2020-08-23T19:42:39Z

aws/resource_aws_sagemaker_endpoint_configuration.go

+	if contentTypeHeader.JsonContentTypes != nil {
+		jsonTypes := make([]map[string]interface{}, 0, len(contentTypeHeader.JsonContentTypes))


same as above

DrFaust92 · 2020-09-23T20:45:12Z

Hey @SaiKiranBurle, can you rebase and address comments? I can fork your repo and finish up the needed changes.

bflad · 2020-10-27T02:25:36Z

@DrFaust92 please feel free to submit new PR including this commit and we'll get it in. 👍

bflad · 2021-01-22T17:40:12Z

It looks like this was covered by #15887, just that GitHub did not automatically close due to the rebased commit SHA.

ghost · 2021-02-22T17:11:49Z

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

Add data capture config to Sagemaker endpoint configuration

da869b2

SaiKiranBurle requested a review from a team January 6, 2020 03:06

DrFaust92 suggested changes Aug 23, 2020

View reviewed changes

bflad added enhancement Requests to existing resources that expand the functionality or scope. waiting-response Maintainers are waiting on response from community or contributor. and removed needs-triage Waiting for first response or review from a maintainer. labels Oct 27, 2020

DrFaust92 self-assigned this Oct 28, 2020

DrFaust92 mentioned this pull request Oct 28, 2020

r/sagemaker_endpoint_configuration - support data_capture_config + validations and test refactor #15887

Merged

bflad closed this Jan 22, 2021

ghost locked as resolved and limited conversation to collaborators Feb 22, 2021

breathingdust removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 17, 2021

DrFaust92 removed their assignment Jun 6, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add data capture config to Sagemaker endpoint configuration #11484

Add data capture config to Sagemaker endpoint configuration #11484

SaiKiranBurle commented Jan 6, 2020

SaiKiranBurle commented Jan 10, 2020

DrFaust92 left a comment

DrFaust92 Aug 23, 2020

DrFaust92 Aug 23, 2020

DrFaust92 Aug 23, 2020

DrFaust92 Aug 23, 2020

DrFaust92 Aug 23, 2020

DrFaust92 Aug 23, 2020

DrFaust92 Aug 23, 2020

DrFaust92 Aug 23, 2020

DrFaust92 commented Sep 23, 2020

bflad commented Oct 27, 2020

bflad commented Jan 22, 2021

ghost commented Feb 22, 2021

		if contentTypeHeader.JsonContentTypes != nil {
		jsonTypes := make([]map[string]interface{}, 0, len(contentTypeHeader.JsonContentTypes))

Add data capture config to Sagemaker endpoint configuration #11484

Add data capture config to Sagemaker endpoint configuration #11484

Conversation

SaiKiranBurle commented Jan 6, 2020

Community Note

SaiKiranBurle commented Jan 10, 2020

DrFaust92 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

DrFaust92 commented Sep 23, 2020

bflad commented Oct 27, 2020

bflad commented Jan 22, 2021

ghost commented Feb 22, 2021