Skip to content

Update versions for release 1.0.1#1751

Closed
curtbushko wants to merge 10 commits intorelease/1.0.xfrom
prerelease/1.0.1
Closed

Update versions for release 1.0.1#1751
curtbushko wants to merge 10 commits intorelease/1.0.xfrom
prerelease/1.0.1

Conversation

@curtbushko
Copy link
Copy Markdown
Contributor

@curtbushko curtbushko commented Nov 21, 2022 •
edited
Loading

Changes proposed in this PR:

How I've tested this PR:

How I expect reviewers to test this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added

    HashiCorp engineers only, community PRs should not add a changelog entry.
    Entries should use present tense (e.g. Add support for...)

@curtbushko curtbushko self-assigned this Nov 21, 2022
@curtbushko curtbushko marked this pull request as ready for review November 21, 2022 21:19
wilkermichael
wilkermichael approved these changes Nov 21, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@wilkermichael wilkermichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

ndhanushkodi
ndhanushkodi approved these changes Nov 21, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@ndhanushkodi ndhanushkodi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

base branch for this should be release/1.0.x right? I don't think we want this in main, I think we could remove the backport label and change the base branch directly

@curtbushko curtbushko changed the base branch from main to release/1.0.x November 21, 2022 21:28
@curtbushko curtbushko closed this Nov 21, 2022
@curtbushko curtbushko deleted the prerelease/1.0.1 branch April 17, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndhanushkodi ndhanushkodi ndhanushkodi approved these changes

+2 more reviewers

@kschoche kschoche kschoche approved these changes

@wilkermichael wilkermichael wilkermichael approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@curtbushko curtbushko

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@curtbushko @ndhanushkodi @kschoche @wilkermichael