remove controller webhook cert roles from vault test and the values.yaml#1740
Merged
remove controller webhook cert roles from vault test and the values.yaml#1740
Conversation
kschoche
requested review from
a team,
jmurret and
thisisnotashwin
and removed request for
a team
thisisnotashwin
approved these changes
Nov 18, 2022
Contributor
thisisnotashwin
left a comment
thisisnotashwin
left a comment
There was a problem hiding this comment.
god's work and all that 🥹
wilkermichael
approved these changes
Nov 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CRD controller deployment no longer exists as it was merged into connect-inject.
Changes proposed in this PR:
How I've tested this PR:
👀
How I expect reviewers to test this PR:
👀
Checklist: