add go-discover binary to control-plane image#1749
Merged
curtbushko merged 3 commits intomainfrom Nov 21, 2022
Merged
Conversation
thisisnotashwin
approved these changes
Nov 21, 2022
Contributor
thisisnotashwin
left a comment
thisisnotashwin
left a comment
There was a problem hiding this comment.
Can we build an image from this ask the person who raised the issue on github to try it?? thanks for taking care of this Curt!
Contributor
Author
|
@thisisnotashwin Yes, I have tagged mr-miles in the github issue and let them know that I would get an image to them if they want to try it out. |
kschoche
reviewed
Nov 21, 2022
kschoche
approved these changes
Nov 21, 2022
Co-authored-by: Kyle Schochenmaier <kschoche@gmail.com>
Contributor
|
We want to backport this to 1.0.x right? Just a reminder to add the label!! Thank you for making the fix! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
How I've tested this PR:
discoverbinary was there and would runHow I expect reviewers to test this PR:
👀
Checklist: