Add fix for api-gateway when using system-wide trusted CAs for external servers#1743
Merged
andrewstucki merged 3 commits intomainfrom Nov 18, 2022
Merged
Add fix for api-gateway when using system-wide trusted CAs for external servers#1743andrewstucki merged 3 commits intomainfrom
andrewstucki merged 3 commits intomainfrom
Conversation
andrewstucki
requested review from
a team,
curtbushko and
wilkermichael
and removed request for
a team
andrewstucki
force-pushed
the
as/system-ca-fix
branch
from
bc47ffe to
8314577
Compare
2 tasks
t-eckert
approved these changes
Nov 18, 2022
2 tasks
2 tasks
andrewstucki
pushed a commit
that referenced
this pull request
Nov 18, 2022
Add fix for api-gateway when using system-wide trusted CAs for external servers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this PR:
This adds some logic that was forgotten around leveraging
externalServers.useSystemRoots. Without it, attempting to use something like HCP as an external server without agents causes the gateway controller to fail validating the Consul server connection since it's using the wrong certificate authority.How I've tested this PR:
Validated against HCP with the api-gateway changes in hashicorp/consul-api-gateway#459
Checklist: