Adds types to FetchService #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffdaley
force-pushed
the
jeffdaley/type-fetch-service
branch
from
1741fa5
to
acc1131
Compare
jeffdaley
force-pushed
the
jeffdaley/type-fetch-service
branch
from
acc1131
to
38447cb
Compare
jfreda
reviewed
Mar 7, 2023
| @@ -93,7 +93,10 @@ export default class DraftsRoute extends Route { | |||
| "/api/v1/drafts?" + | |||
| this.createDraftURLSearchParams(params, ownerFacetOnly) | |||
| ) | |||
| .then((response) => response.json()); | |||
| .then((response) => { | |||
| assert("response must be defined", response); | |||
There was a problem hiding this comment.
I'm curious about the uses of assert in this PR because assertions are removed for production builds - can you explain the intent behind these?
There was a problem hiding this comment.
To pass type checking and hopefully to pinpoint errors better in development. resp can be undefined so we have to assert it or invoke it with a question mark resp?.json(). I expect a response so I opted to assert it.
There was a problem hiding this comment.
Thinking about this a little more. I see where you're coming from. It's both more succinct and more true to use the resp?.json() invocation. Any benefit of assertion-error proximity is minimal. I'm going to change the approach!
jfreda
approved these changes
Mar 22, 2023
anuragprafulla
referenced
this pull request
in razorpay/hermes
Jun 27, 2023
* Adds types to FetchService * Update maybeUndefined * Add fetch to tsconfig * Fix type errors * Update people-select.ts * Remove unnecessary import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds types to the FetchService