Add Fetch path to tsconfig; update response types
#80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfreda
approved these changes
Mar 13, 2023
Comment on lines
+82
to
+87
| method: "GET", | ||
| headers: { | ||
| "Hermes-Google-Access-Token": | ||
| this.session.data.authenticated.access_token, | ||
| }, | ||
| }) |
There was a problem hiding this comment.
Not a blocker, but we shouldn't need this anymore with how we now automatically add the auth header to requests to the backend in the fetch service:
hermes/web/app/services/fetch.ts
Lines 13 to 19 in 5712506
There was a problem hiding this comment.
Good catch. Addressed separately at #91
anuragprafulla
pushed a commit
to razorpay/hermes
that referenced
this pull request
Jun 27, 2023
* Add fetch to tsconfig * Fix type errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the type path for the
ember-fetchaddon.This revealed a few type errors, which I've fixed here.
Once this is merged #45 resolve quickly.