Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds types to FetchService #45

Merged
merged 13 commits into from
Mar 22, 2023
Merged

Adds types to FetchService #45

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
38447cb
Adds types to FetchService
jeffdaley Feb 10, 2023
62ef4ad
Merge branch 'main' into jeffdaley/type-fetch-service
jeffdaley Feb 23, 2023
17a5681
Merge branch 'main' into jeffdaley/type-fetch-service
jeffdaley Mar 3, 2023
5b7b07e
Update maybeUndefined
jeffdaley Mar 7, 2023
e78c4d5
Merge branch 'main' into jeffdaley/type-fetch-service
jeffdaley Mar 7, 2023
887b717
Add fetch to tsconfig
jeffdaley Mar 8, 2023
5712506
Fix type errors
jeffdaley Mar 8, 2023
a3c87f3
Merge branch 'main' into jeffdaley/type-fetch-service
jeffdaley Mar 8, 2023
fffd34b
Merge branch 'jeffdaley/fetch' into jeffdaley/type-fetch-service
jeffdaley Mar 8, 2023
b0e88ce
Update people-select.ts
jeffdaley Mar 8, 2023
27c8ff0
Merge branch 'main' into jeffdaley/type-fetch-service
jeffdaley Mar 13, 2023
618b121
Remove unnecessary import
jeffdaley Mar 13, 2023
349ab95
Merge branch 'main' into jeffdaley/type-fetch-service
jeffdaley Mar 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions web/app/services/fetch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,20 @@
// @ts-nocheck
// TODO: Type this file.
import Service from "@ember/service";
import fetch from "fetch";
import { inject as service } from "@ember/service";
import SessionService from "./session";

interface FetchOptions {
method?: string;
headers?: {
[key: string]: string;
};
body?: string;
}

export default class FetchService extends Service {
@service session;
@service declare session: SessionService;

async fetch(url, options = {}) {
async fetch(url: string, options: FetchOptions = {}) {
// Add the Google access token in a header (for auth) if the URL starts with
// a frontslash, which will only target the application backend.
if (Array.from(url)[0] == "/") {
Expand All @@ -18,7 +25,6 @@ export default class FetchService extends Service {
};
}
try {

const resp = await fetch(url, options);

if (!resp.ok) {
Expand Down