-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added anchors to headers in documentation #1395
Conversation
Github does it natively on READMEs and stuff using their Octicons font. Dunno what the support is for hotlinking their shit and using it on GH Pages, but you could attempt to use their same |
Yeah. And I could not find anywhere that allowed me to download or use it. I figured it would be in bad style to do so. |
I think we should make the entire title be a link, and on |
@starzonmyarmz Fine by me. Do you want me to update it now before you mess with an icon? |
I'll take care of it! |
Wrapped the text inside of the <h2> tags with anchors, and added an icon to appear on :hover.
Nice. One small thing, though. Since this is very similar to the way GH anchor links work, it might be confusing that the icon goes away when you try to directly click on it. How much trouble would it be to have that stay visible and clickable? |
Fixed |
great idea ! |
@starzonmyarmz Cool. Although we need to update the |
@@ -199,6 +199,10 @@ | |||
</tr> | |||
</table> | |||
|
|||
<footer> | |||
© 2011 <a href="http://www.getharvest.com/">Harvest</a> - Chosen is licensed under the <a href="http://en.wikipedia.org/wiki/MIT_License">MIT license</a>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two space indent instead of the one that's here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kenearley I'll grab that tomorrow |
@starzonmyarmz I'll do it. :) |
@pfiller I believe this is good to go now. |
@@ -16,7 +16,7 @@ | |||
<div id="container"> | |||
<div id="content"> | |||
<header> | |||
<h1>Chosen</h1> | |||
<h1>Chosen</h1> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did this indent go away?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure. I'll fix it.
done |
Add anchors to documentation headers
Thanks @kenearley and @starzonmyarmz |
- CSS Updates #1368, #1371 - Prevent text selection on Chosen #1374 - single_backstroke_delete defaults to true #1375 - No longer expose classes to window context #1389 - Single select value fix #1392 - Remove javascript:void and attr references #1385, #1377 - Disable Chosen on iPhone / iPod and Android mobile devices by default #1388 - Add Destroy Method #1396 - Option to Hide Selected & Disabled Options #1404 - Always clear result highlight #1407 - Replace characters only once #1411 - Document all the things. #1366, #1376, #1383 - Add Gemfile for compass dependency #1373 - Update copyright and license link #1397 - Add @koenpunt as a maintainer #1399 - Add anchors to documentation headers #1395 - Updated stackoverflow instructions #1403
@harvesthq/chosen-developers We can now give people links to the sections in the documentation to help answer their questions.
@starzonmyarmz Could you give me a hand to replace the 'link' text with a nice icon?
Open Issues