Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Css updates #1368

Merged
merged 2 commits into from
Jul 17, 2013
Merged

Css updates #1368

merged 2 commits into from
Jul 17, 2013

Conversation

pfiller
Copy link
Contributor

@pfiller pfiller commented Jul 17, 2013

@mlettini I'm looking for your +1 on this

@kenearley @stof @koenpunt @starzonmyarmz you guys should be aware of the change

This does two things:

  • Changes the style of optgroups to be black. They look better, are easier to read and more closely match default select styles this way
  • Change the specificity of our input styling. This should help with some of the "Bootstrap styles are off"-type issues we've been seeing a lot of (like Chosen with bootstrap, styles a bit goofy #1263)

Pretty low-risk.

pfiller added 2 commits July 17, 2013 17:38
This matches Chosen more closely to standard HTML Selects and makes
groups easier to read.
This helps solve problems with inhertence when dropping Chosen into
a page that also uses the type="text" level of specificty. The more
specific the CSS selector, the higher its precedence.
@mlettini
Copy link

👊! adding [type="text"] should definitely help when some sites default input styles are overriding ours.

pfiller added a commit that referenced this pull request Jul 17, 2013
@pfiller pfiller merged commit 3ce9adc into master Jul 17, 2013
@pfiller pfiller deleted the css-updates branch July 17, 2013 22:00
pfiller added a commit that referenced this pull request Jul 26, 2013
- CSS Updates #1368, #1371
- Prevent text selection on Chosen #1374
- single_backstroke_delete defaults to true #1375
- No longer expose classes to window context #1389
- Single select value fix #1392
- Remove javascript:void and attr references #1385, #1377
- Disable Chosen on iPhone / iPod and Android mobile devices
  by default #1388
- Add Destroy Method #1396
- Option to Hide Selected & Disabled Options #1404
- Always clear result highlight #1407
- Replace characters only once #1411

- Document all the things. #1366, #1376, #1383
- Add Gemfile for compass dependency #1373
- Update copyright and license link #1397
- Add @koenpunt as a maintainer #1399
- Add anchors to documentation headers #1395
- Updated stackoverflow instructions #1403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants