Add Gemfile for compass dependency #1373
Conversation
|
Good call! I should've put that in while switching to sass. |
|
Just curious, doesn't adding a Gemfile just add another dependency? Now you need to do a |
|
@kenearley you can still use a global installation of compass with |
|
Makes sense to me. |
|
@kenearley You're right that I prefer adding it via Bundler because that effectively becomes executable documentation. It also gives us a future place to add other gem dependencies if we need them, and allows us to do more fine-tuned locking down of things like version just in case we have a later version requirement. Since this is only a dev dependency, I think doing it this way is okay, but I'm a Rubyist :) @pfiller You have an opinion? |
|
I've got no problem with this. We should probably update our instructions on building Chosen to include Compass. |
…ndency Add Gemfile for compass dependency
- CSS Updates #1368, #1371 - Prevent text selection on Chosen #1374 - single_backstroke_delete defaults to true #1375 - No longer expose classes to window context #1389 - Single select value fix #1392 - Remove javascript:void and attr references #1385, #1377 - Disable Chosen on iPhone / iPod and Android mobile devices by default #1388 - Add Destroy Method #1396 - Option to Hide Selected & Disabled Options #1404 - Always clear result highlight #1407 - Replace characters only once #1411 - Document all the things. #1366, #1376, #1383 - Add Gemfile for compass dependency #1373 - Update copyright and license link #1397 - Add @koenpunt as a maintainer #1399 - Add anchors to documentation headers #1395 - Updated stackoverflow instructions #1403
@kenearley There's a dev dependency on Compass -- this adds a Gemfile to hopefully convey that, but at least to codify it. Couldn't
grunt buildwithout it.