-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added events example and descriptions to documentation #1376
Conversation
@@ -157,6 +157,44 @@ | |||
</td> | |||
<tr> | |||
</table> | |||
|
|||
<h2>Events</h2> | |||
<p>Chosen fires events to which you can attach listeners.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should make it more clear that you listen to these events on the original select field. Something like:
"Chosen triggers a number of standard and custom events on the original select field."
Awesome! Thanks @kenearley. A few easy things, but otherwise good to go! |
</tr> | ||
<tr> | ||
<td>liszt:hiding_dropdown</td> | ||
<td>triggered when Chosen's dropdown is closed.</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All the liszt:*
events are receiving a chosen
parameter with the Chosen instance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh - I totally forgot about that. Definitely worth adding to the docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm on it.
params info added. |
Going to merge this. If further changes need to be made, do them in master. |
Added events example and descriptions to documentation
Thanks @kenearley |
- CSS Updates #1368, #1371 - Prevent text selection on Chosen #1374 - single_backstroke_delete defaults to true #1375 - No longer expose classes to window context #1389 - Single select value fix #1392 - Remove javascript:void and attr references #1385, #1377 - Disable Chosen on iPhone / iPod and Android mobile devices by default #1388 - Add Destroy Method #1396 - Option to Hide Selected & Disabled Options #1404 - Always clear result highlight #1407 - Replace characters only once #1411 - Document all the things. #1366, #1376, #1383 - Add Gemfile for compass dependency #1373 - Update copyright and license link #1397 - Add @koenpunt as a maintainer #1399 - Add anchors to documentation headers #1395 - Updated stackoverflow instructions #1403
@pfiller I just copy/pasted the event descriptions you posted in #227. I added an example for the change event, since that seemed like the most complex one.