Sync with ESCOMP/master to bring component level PIO initialization#2
Closed
uturuncoglu wants to merge 19 commits into
Closed
Sync with ESCOMP/master to bring component level PIO initialization#2uturuncoglu wants to merge 19 commits into
uturuncoglu wants to merge 19 commits into
Conversation
This fixes a bug in running the test SMS_Ln9_P4_Vnuopc.f19_f19.A.cheyenne_intel
replace musgs with mg37 in cdeps tests
Jedwards/namelist cleanup
Description of changes
Replace DATM_CLMNCEP_YR and DATM_CPLHIST_YR with DATM_YR - there is no need to distinguish these. Also change
scol_mode = 'true' and create_mesh = 'true' in namelist_definition_datm.xml with mode='single_column', mode='create'.
Tested aux_cdeps (against feb0121) and cmeps testlist_drv (against jan17)
Specific notes
Contributors other than yourself, if any:
CMEPS Issues Fixed (include github issue #):
Are there dependencies on other component PRs
CIME (list)
CMEPS (list)
Are changes expected to change answers?
bit for bit
different at roundoff level
more substantial
Any User Interface Changes (namelist or namelist defaults changes)?
Yes See description above.
No
Testing performed:
(required) aux_cdeps
machines and compilers: Cheyenne intel
details (e.g. failed tests): All pass
(optional) CESM prealpha test
machines and compilers
details (e.g. failed tests):
Hashes used for testing:
CIME
repository to check out: https://github.com/ESCOMP/CESM.git
branch: master
hash:ef6b28c80
CMEPS
repository to check out: https://github.com/ESCOMP/CESM.git
branch: master
hash:ff6ec1977
CESM
repository to check out: https://github.com/ESCOMP/CESM.git
branch: nuopc_dev
hash:c019fc221
Component level PIO initialization for external applications such as HAFS
5 tasks
Collaborator
|
@uturuncoglu In order to not break the support/HAFS branch at the model level, please hold this PR so that it goes back into the support/HAFS branch together with the following PRs: |
Collaborator
Author
|
@BinLiu-NOAA sure. I am waiting for your approval. |
danrosen25
reviewed
Mar 15, 2021
danrosen25
left a comment
danrosen25
left a comment
There was a problem hiding this comment.
I'm not familiar with the CDEPS component code or testing. If this has been tested then I approve.
Collaborator
Author
|
@danrosen25 I run full aux tests in CDEPs side as well ass full CESM test suit and it has lots of configurations combining active components with data components under CDEPS. So, all of them passed without any problem. |
BinLiu-NOAA
pushed a commit
that referenced
this pull request
Apr 16, 2021
Update CDEPS to the 20201124 version of the master branch at ESCOMP/CDEPS.
Collaborator
Author
|
I think that we don't need this once we sync with NOAA/EMC fork. So, I am closing this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This PR aims to bring component level PIO initialization to support/HAFS
Specific notes
Contributors other than yourself, if any: None
CDEPS Issues Fixed (include github issue #): None
Testing performed: