Jedwards/namelist cleanup#49
Merged
Merged
Conversation
Collaborator
|
Thank you for doing this. All looks good. Please summarize your testing. I assume that all the results are bfb. |
Collaborator
|
Also - please summarize the namelist changes - and xml file changes - since that is part of this PR and is in the template. |
Contributor
Author
|
@mvertens ready for review |
Collaborator
|
Can you please fill in if changes are expected to change answers. What baselines did you compare against? If you created baselines with the old code and then used the updated code to compare - please summarize this. Did you generate new baselines? Please document this. |
Collaborator
|
Also - do these changes depend on a CIME hash? |
Contributor
Author
|
@mvertens I've updated the comment with the details you've requested. |
mvertens
approved these changes
Feb 4, 2021
uturuncoglu
pushed a commit
to uturuncoglu/CDEPS
that referenced
this pull request
Oct 5, 2022
Update CDEPS to include the recent changes from ESCOMP/CDEPS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Replace DATM_CLMNCEP_YR and DATM_CPLHIST_YR with DATM_YR - there is no need to distinguish these. Also change
scol_mode = 'true' and create_mesh = 'true' in namelist_definition_datm.xml with mode='single_column', mode='create'.
Tested aux_cdeps (against feb0121) and cmeps testlist_drv (against jan17)
Specific notes
Contributors other than yourself, if any:
CMEPS Issues Fixed (include github issue #):
Are there dependencies on other component PRs
Are changes expected to change answers?
Any User Interface Changes (namelist or namelist defaults changes)?
Testing performed:
Hashes used for testing: