Skip to content

Jedwards/namelist cleanup#49

Merged
jedwards4b merged 5 commits into
ESCOMP:masterfrom
jedwards4b:jedwards/namelist_cleanup
Feb 4, 2021
Merged

Jedwards/namelist cleanup#49
jedwards4b merged 5 commits into
ESCOMP:masterfrom
jedwards4b:jedwards/namelist_cleanup

Conversation

@jedwards4b
Copy link
Copy Markdown
Contributor

@jedwards4b jedwards4b commented Feb 1, 2021

Description of changes

Replace DATM_CLMNCEP_YR and DATM_CPLHIST_YR with DATM_YR - there is no need to distinguish these. Also change
scol_mode = 'true' and create_mesh = 'true' in namelist_definition_datm.xml with mode='single_column', mode='create'.
Tested aux_cdeps (against feb0121) and cmeps testlist_drv (against jan17)

Specific notes

Contributors other than yourself, if any:

CMEPS Issues Fixed (include github issue #):

Are there dependencies on other component PRs

  • CIME (list)
  • CMEPS (list)

Are changes expected to change answers?

  • bit for bit
  • different at roundoff level
  • more substantial

Any User Interface Changes (namelist or namelist defaults changes)?

  • Yes See description above.
  • No

Testing performed:

  • (required) aux_cdeps
    • machines and compilers: Cheyenne intel
    • details (e.g. failed tests): All pass
  • (optional) CESM prealpha test
    • machines and compilers
    • details (e.g. failed tests):

Hashes used for testing:

@jedwards4b jedwards4b requested a review from mvertens February 1, 2021 22:02
@jedwards4b jedwards4b self-assigned this Feb 1, 2021
@jedwards4b jedwards4b marked this pull request as draft February 1, 2021 22:02
@mvertens
Copy link
Copy Markdown
Collaborator

mvertens commented Feb 2, 2021

Thank you for doing this. All looks good. Please summarize your testing. I assume that all the results are bfb.

@mvertens
Copy link
Copy Markdown
Collaborator

mvertens commented Feb 2, 2021

Also - please summarize the namelist changes - and xml file changes - since that is part of this PR and is in the template.

@jedwards4b jedwards4b marked this pull request as ready for review February 2, 2021 20:13
@jedwards4b
Copy link
Copy Markdown
Contributor Author

@mvertens ready for review

@mvertens
Copy link
Copy Markdown
Collaborator

mvertens commented Feb 4, 2021

Can you please fill in if changes are expected to change answers. What baselines did you compare against? If you created baselines with the old code and then used the updated code to compare - please summarize this. Did you generate new baselines? Please document this.

@mvertens
Copy link
Copy Markdown
Collaborator

mvertens commented Feb 4, 2021

Also - do these changes depend on a CIME hash?

@jedwards4b
Copy link
Copy Markdown
Contributor Author

@mvertens I've updated the comment with the details you've requested.

@jedwards4b jedwards4b merged commit 1f02a73 into ESCOMP:master Feb 4, 2021
@jedwards4b jedwards4b deleted the jedwards/namelist_cleanup branch February 4, 2021 18:36
uturuncoglu pushed a commit to uturuncoglu/CDEPS that referenced this pull request Oct 5, 2022
Update CDEPS to include the recent changes from ESCOMP/CDEPS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants