Skip to content

Sync with ESCOMP/master to bring component level PIO initialization#1

Merged
BinLiu-NOAA merged 19 commits into
support/HAFSfrom
feature/pio_fix_comp
Apr 17, 2021
Merged

Sync with ESCOMP/master to bring component level PIO initialization#1
BinLiu-NOAA merged 19 commits into
support/HAFSfrom
feature/pio_fix_comp

Conversation

@uturuncoglu
Copy link
Copy Markdown

Description of changes

This PR aims to bring component level PIO initialization to support/HAFS

Specific notes

Contributors other than yourself, if any: None

CMEPS Issues Fixed (include github issue #): None

Are changes expected to change answers?

  • bit for bit
  • different at roundoff level
  • more substantial

Any User Interface Changes (namelist or namelist defaults changes)?

  • Yes
  • No

Testing performed:

  • Full RTs are run in HAFS model level without any problem
  • S2S is tested externally by Denise and it is bit-to-bit reproducable
  • HAFS fully coupled application is also tested through the use of HAFS application and it was Bir-to-bit reproducible
  • The available data model regression tests are run without any problem: DATM+DOCN, DATM+HYCOM and FV3+DOCN(regional).
  • CESM full test suit also run and all tests were passed

Mariana Vertenstein and others added 19 commits January 20, 2021 10:14
bugfix for cart3d and other changes needed for CESM validation
Description of changes

bugfix for cart3d and other changes needed for CESM validation
Specific notes

This PR does several things

    med_map_mod.F90 has a fix for the cart3d mapping - in addition, this is now the default mapping for CESM as is the case with mct
    testlist_drv.xml has been modified to include a new compset for MOM
    bug fix in med_io_mod to permit more ungridded dimensions than 16

NOTE: the externals used for CESM for the testing has been changed such that all components have been updated to have flux area corrections implemented in their caps AND also many have been updated to be near their master versions. As a result all baseline answers are different.

Contributors other than yourself, if any: None

CMEPS Issues Fixed: None

Are changes expected to change answers?

bit for bit
different at roundoff level

    more substantial - only for CESM testing, other model testing should be bfb

Any User Interface Changes (namelist or namelist defaults changes)?

Yes

    No

Testing performed if application target is CESM:(either UFS-S2S or CESM testing is required):

(recommended) CIME_DRIVER=nuopc scripts_regression_tests.py

    machines:
    details (e.g. failed tests):

(recommended) CESM testlist_drv.xml

    machines and compilers: cheyenne/intel
    details (e.g. failed tests): No failed tests - but baselines are different, new baselines are feb02

(optional) CESM prealpha test

    machines and compilers
    details (e.g. failed tests):

    (other) please described in detail
        machines and compilers
        details (e.g. failed tests):

Testing performed if application target is UFS-coupled:

    (recommended) UFS-coupled testing
        description:
        details (e.g. failed tests):

Testing performed if application target is UFS-HAFS:

    (recommended) UFS-HAFS testing
        description:
        details (e.g. failed tests):

Hashes used for testing:

CESM:

    repository to check out: https://github.com/ESCOMP/CESM.git
    branch: nuopc_dev
    hash: c6121e3

[x ] UFS-coupled, then umbrella repostiory to check out and associated hash:

    repository to check out:https://github.com/ufs-community/ufs-weather-model
    branch: develop, with switch to this cmeps branch
    hash: e3983a0

UFS-HAFS, then umbrella repostiory to check out and associated hash:

    repository to check out:
    branch:
    hash:
Component level PIO initialization for external applications such as HAFS
Copy link
Copy Markdown

@BinLiu-NOAA BinLiu-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@BinLiu-NOAA
Copy link
Copy Markdown

@uturuncoglu In order to not break the support/HAFS branch at the model level, please hold this PR so that it goes back into the support/HAFS branch together with the following PRs:
hafs-community/ufs-weather-model#8
hafs-community/CDEPS#2
hafs-community/NEMS#3

@uturuncoglu
Copy link
Copy Markdown
Author

@BinLiu-NOAA sure. I am waiting for your approval.

@BinLiu-NOAA BinLiu-NOAA requested a review from danrosen25 March 12, 2021 22:42
Copy link
Copy Markdown
Collaborator

@danrosen25 danrosen25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This work was approved here:
ESCOMP#158
The rest of the changes are related to synchronizing hafs-community with the latest ESCOMP work.

@BinLiu-NOAA BinLiu-NOAA merged commit 756c7f7 into support/HAFS Apr 17, 2021
@BinLiu-NOAA BinLiu-NOAA deleted the feature/pio_fix_comp branch July 28, 2021 21:23
BinLiu-NOAA pushed a commit that referenced this pull request Jul 22, 2023
BinLiu-NOAA pushed a commit that referenced this pull request Feb 1, 2024
Exchange grid updates from Dom 2022/01/30
BinLiu-NOAA pushed a commit that referenced this pull request Feb 1, 2024
minor fixes for ww3/cice coupling and update of code to cmeps0.14.24.
BinLiu-NOAA pushed a commit that referenced this pull request Feb 1, 2024
make history_n integer variables
BinLiu-NOAA pushed a commit that referenced this pull request Feb 1, 2024
Gust mods suggested changes for cam_dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants