Remove driver level PIO initialization#3
Conversation
|
@uturuncoglu In order to not break the support/HAFS branch at the model level, please hold this PR so that it goes back into the support/HAFS branch together with the following PRs: |
|
@BinLiu-NOAA sure. I am waiting for your approval. |
danrosen25
left a comment
danrosen25
left a comment
There was a problem hiding this comment.
I suggest cleaning up a few hanging variables before approving.
| !*** Initialize PIO. 8 is the maximum number of component models | ||
| !----------------------------------------------------------------------- | ||
| ! | ||
| COMM_WORLD = MPI_COMM_WORLD |
There was a problem hiding this comment.
Please remove line 121 if no longer needed. INTEGER :: COMM_WORLD
| line=__LINE__, file=trim(name)//":"//__FILE__)) return ! bail out | ||
|
|
||
| ! get MPI communicator | ||
| call ESMF_VMGet(vm, mpiCommunicator=Global_Comm, rc=rc) |
There was a problem hiding this comment.
VM is no longer needed. See lines
- 3407
- 3426
- 4576
|
@BinLiu-NOAA @danrosen25 i am closing this PR because this branch is outdated and I need to work again. I'll create another branch for CDEPS sync and make PR again. Then we could clean the unused branches. |
3 participants
This PR aims to remove the modifications that was done previously to bring PIO initialization to NEMS driver. Since both CMEPS (hafs-community/CMEPS#1) and CDEPS (hafs-community/CDEPS#2) are modified to have component level PIO initialization, there is no need to keep those modifications in the NEMS level.
Tests: