Repository navigation
hotfix: remove 4 orphaned #[cfg(test)] attributes breaking clippy on main - #6141
Merged
Merged
Conversation
…ion mod deletes PRs #6131/#6132/#6133/#6139 deleted 'mod <x>_test;' lines but left each line's own #[cfg(test)] attribute, which now stacks onto the next declaration — clippy::duplicated_attributes reds the v1 rust gate (fmt+clippy+nextest) on main. Pure attribute cleanup, no behavior change. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gunbai-bot Bot
pushed a commit
that referenced
this pull request
Jul 2, 2026
…tness authored) Test 1 (currency.dag resolves) is covered by the floor batch-1 dsl_compile_clean_gate; test 2's cost_projection_float_witness is now floor-enrolled via the new dsl/test/claim/cost_estimate_float_witness_test.dag marker witness. Also dedups the orphaned #[cfg(test)] attributes inherited from main (#6141 overlap). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gunbai-bot Bot
pushed a commit
that referenced
this pull request
Jul 2, 2026
cron_tag_upsert_protocol_keystone_holds is now floor-enrolled via the new dsl/test/claim/cron_tag_witness_test.dag marker witness. The v1 module's second test (in-memory got==want -> got!=want mutation check) is carried as this PR's perturb->red receipt instead. mod line removed together with its own #[cfg(test)] attribute; inherited duplicate attributes deduped (#6141 overlap). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
gunbai-bot Bot
pushed a commit
that referenced
this pull request
Jul 2, 2026
…red) repeat_string count semantics + indent-style padding are now floor-enrolled via dsl/test/claim/render_repeat_string_witness_test.dag. mod line removed with its #[cfg(test)] attribute; inherited duplicate attributes deduped (#6141 overlap). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
briansrls
added a commit
that referenced
this pull request
Jul 2, 2026
…nesses; v1 module shrunk to 2 residual tests (#6140) * wip: fn_as_value floor witnesses * fix chained access to record equality (mirrors v1 Record assertion) * PERTURB (temporary): unify_generics never binds type params * Revert "PERTURB (temporary): unify_generics never binds type params" This reverts commit 4b62e06. * 5-test-migration: migrate fn_as_value_test — 6 checks to new floor witness file, module shrunk to 2 residual tests New src/v2/test/claim/manual/fn_as_value_test.dag carries the six migratable checks as marker-discovered test fns (first-class fn binding + generic instantiation family); the two fold_list checks were already floor-covered by generic_instantiation_runtime_test.dag. Residual v1 tests (documented in the module header): the Rust-loader-coupled scoped-entry test and the negative fail-closed test blocked on the inert ExpectFail floor mechanism. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * WIP: 5-test-migration — v1 burn-down: migrate v1 Rust test modules (~90 modul * dedup orphaned #[cfg(test)] attributes inherited from merged deletion PRs (see #6141) --------- Co-authored-by: Brian Searls <briansearls1@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
briansrls
added a commit
that referenced
this pull request
Jul 2, 2026
…harness tests deleted; module shrunk to pinned-harness residual (#6142) * PERTURB (temporary): reflection drops the first nullary arm * Revert "PERTURB (temporary): reflection drops the first nullary arm" This reverts commit 9508fa3. * 5-test-migration: shrink coproduct_reflection_conformance_test to its pinned-harness residual Tests 2-4 were duplicate harnesses invoking floor-enrolled witnesses (coproduct_reflection_conformance_test.dag's 4 test fns + concept_index_enumeration_test.dag's concept_index_enumeration_witnesses). Receipts: 5/5 PASS via claim_batch; perturb at the live realization layer (coproduct_reflection.rs eval_coproduct_nullary_inhabitants skipping the first arm) reds conformance + nullary-set witnesses while the arm-set-distinct control stays green; perturb commit reverted in-branch. Residual test 1 scans v1_interpreter.rs for intercept wiring — a pinned-harness fact. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * dedup orphaned #[cfg(test)] attributes inherited from main (fix lands in #6141) --------- Co-authored-by: Brian Searls <briansearls1@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
briansrls
added a commit
that referenced
this pull request
Jul 2, 2026
…v1 module deleted (#6143) * wip: cost_estimate float witness * PERTURB (temporary): billable_hours multiplies -> adds * Revert "PERTURB (temporary): billable_hours multiplies -> adds" This reverts commit 4fe27ac. * 5-test-migration: delete v1 money_carrier_cost_witness_test (floor witness authored) Test 1 (currency.dag resolves) is covered by the floor batch-1 dsl_compile_clean_gate; test 2's cost_projection_float_witness is now floor-enrolled via the new dsl/test/claim/cost_estimate_float_witness_test.dag marker witness. Also dedups the orphaned #[cfg(test)] attributes inherited from main (#6141 overlap). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Brian Searls <briansearls1@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
briansrls
added a commit
that referenced
this pull request
Jul 2, 2026
…6145) * wip: cron_tag floor witness * PERTURB (temporary): invert cron_tag verify comparison * Revert "PERTURB (temporary): invert cron_tag verify comparison" This reverts commit ea9e7f6. * 5-test-migration: delete v1 cron_tag_test (floor witness authored) cron_tag_upsert_protocol_keystone_holds is now floor-enrolled via the new dsl/test/claim/cron_tag_witness_test.dag marker witness. The v1 module's second test (in-memory got==want -> got!=want mutation check) is carried as this PR's perturb->red receipt instead. mod line removed together with its own #[cfg(test)] attribute; inherited duplicate attributes deduped (#6141 overlap). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Brian Searls <briansearls1@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
briansrls
added a commit
that referenced
this pull request
Jul 2, 2026
…eleted (#6147) * wip: render_repeat floor witnesses * PERTURB (temporary): repeat_string_loop decrements by 2 * Revert "PERTURB (temporary): repeat_string_loop decrements by 2" This reverts commit 0cb07b3. * 5-test-migration: delete v1 render_repeat_test (floor witnesses authored) repeat_string count semantics + indent-style padding are now floor-enrolled via dsl/test/claim/render_repeat_string_witness_test.dag. mod line removed with its #[cfg(test)] attribute; inherited duplicate attributes deduped (#6141 overlap). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Brian Searls <briansearls1@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main is red on the
rust_testsgate (clippy::duplicated_attributesunder-D warnings): the four merged test-migration deletion PRs (#6131 #6132 #6133 #6139) each removed amod <x>_test;line fromsrc/v1/tests/src/lib.rsbut left that line's own#[cfg(test)]attribute orphaned, stacking it onto the following declaration. My error in those PRs (sed deleted only themodline); this removes the 4 duplicate attributes. Verified:cargo clippy -p v1-compiler-tests --all-targets -- -D warningsgreen at this head.Also note: per project memory, clippy was previously believed non-CI-gated; the live
rust_testsjob (v1 rust gate (fmt + clippy + nextest)) DOES run clippy now — the failures on #6132/#6133 rust_tests jobs are this exact break.🤖 Generated with Claude Code