Repository navigation
5-test-migration (3): delete v1 node_minimal_representation_test — floor witnesses already cover it - #6133
Merged
Conversation
…itnesses cover it) The v1 Rust module was a duplicate harness: it resolved src/v2/test/claim/manual/node_minimal_representation_test.dag and invoked 9 of its 10 'test fn' witnesses via the v1 interpreter. All 10 are marker-discovered floor witnesses (src/v2 source-root pass; the dir is also a live witness_discovery_scan_dirs entry), run 10/10 green via claim_batch, and are discriminating: dropping NsfTypeAnnotation from minimal_kind_owed_placement reds witness_partition_covers_superset_holds and node_minimal_owed_bucket_count_holds while an unrelated witness stays green (perturb commit reverted in-branch). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This reverts commit 1cda9ce.
briansrls
pushed a commit
that referenced
this pull request
Jul 2, 2026
…ion mod deletes (#6141) PRs #6131/#6132/#6133/#6139 deleted 'mod <x>_test;' lines but left each line's own #[cfg(test)] attribute, which now stacks onto the next declaration — clippy::duplicated_attributes reds the v1 rust gate (fmt+clippy+nextest) on main. Pure attribute cleanup, no behavior change. Co-authored-by: Brian Searls <briansearls1@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third PR of the 5-test-migration lane (v1 burn-down). Net diff vs main is pure deletion —
git diff origin/main -- src/v2 dslis empty (the in-branch perturb commit is reverted; squash-merge flattens it).What
Delete
src/v1/tests/src/node_minimal_representation_test.rs(149 LOC, 1#[test]) and itsmodline inlib.rs.Why the floor fully covers it
The v1 module was a duplicate harness: it resolved
src/v2/test/claim/manual/node_minimal_representation_test.dagand invoked 9 of its 10test fnwitnesses through the v1 interpreter, assertingBool(true)for each. All 10test fns are floor-enrolled: the file is under thesrc/v2witness layer root (*_test.dagmarker discovery), andsrc/v2/test/claim/manualis additionally a livewitness_discovery_scan_dirsentry (cli_run.rs authority projection). Floor coverage is a strict superset of the v1 module's 9 invocations. No hand-enrollment added.Receipts (green-by-execution + perturb→red)
claim_batch --source-root src/v2 --source-root dsl --entry src/v2/test/claim/manual/node_minimal_representation_test.dag --functions <all 10>→ 10/10 PASS (1 resolve 1546ms, exit 0).NsfTypeAnnotationfromminimal_kind_owed_placementinsrc/v2/std/node_minimal.dag, commit1cda9ceb9, reverted in-branch):witness_partition_covers_superset_holds→ FAILnode_minimal_owed_bucket_count_holds→ FAILnode_minimal_kind_of_expr_leaf_holds→ PASS (unrelated control), exit 1.cargo test -p v1-compiler-tests --no-runcompiles clean after the delete.Mapping note
Everything the v1 module asserted (clean resolve of the entry; 9 witnesses true) is subsumed by floor execution of the same witnesses; the 10th
test fn(node_minimal_roster_length_matches_superset_count_holds) was floor-only already. Nothing remains un-migrated for this module.🤖 Generated with Claude Code