Skip to content

5-test-migration (3): delete v1 node_minimal_representation_test — floor witnesses already cover it - #6133

Merged
briansrls merged 3 commits into
mainfrom
test-migration/node-minimal-representation
Jul 2, 2026
Merged

briansrls merged 3 commits into
mainfrom
test-migration/node-minimal-representation

Conversation

@briansrls

@briansrls briansrls commented Jul 2, 2026 •

Copy link
Copy Markdown
Contributor

Third PR of the 5-test-migration lane (v1 burn-down). Net diff vs main is pure deletion — git diff origin/main -- src/v2 dsl is empty (the in-branch perturb commit is reverted; squash-merge flattens it).

What

Delete src/v1/tests/src/node_minimal_representation_test.rs (149 LOC, 1 #[test]) and its mod line in lib.rs.

Why the floor fully covers it

The v1 module was a duplicate harness: it resolved src/v2/test/claim/manual/node_minimal_representation_test.dag and invoked 9 of its 10 test fn witnesses through the v1 interpreter, asserting Bool(true) for each. All 10 test fns are floor-enrolled: the file is under the src/v2 witness layer root (*_test.dag marker discovery), and src/v2/test/claim/manual is additionally a live witness_discovery_scan_dirs entry (cli_run.rs authority projection). Floor coverage is a strict superset of the v1 module's 9 invocations. No hand-enrollment added.

Receipts (green-by-execution + perturb→red)

  1. Green: claim_batch --source-root src/v2 --source-root dsl --entry src/v2/test/claim/manual/node_minimal_representation_test.dag --functions <all 10> → 10/10 PASS (1 resolve 1546ms, exit 0).
  2. Discriminating (perturb→red): temporarily committed a subject perturbation (drop NsfTypeAnnotation from minimal_kind_owed_placement in src/v2/std/node_minimal.dag, commit 1cda9ceb9, reverted in-branch):
    • witness_partition_covers_superset_holds → FAIL
    • node_minimal_owed_bucket_count_holds → FAIL
    • node_minimal_kind_of_expr_leaf_holds → PASS (unrelated control), exit 1.
  3. cargo test -p v1-compiler-tests --no-run compiles clean after the delete.

Mapping note

Everything the v1 module asserted (clean resolve of the entry; 9 witnesses true) is subsumed by floor execution of the same witnesses; the 10th test fn (node_minimal_roster_length_matches_superset_count_holds) was floor-only already. Nothing remains un-migrated for this module.

🤖 Generated with Claude Code

Brian Searls and others added 3 commits July 2, 2026 04:29
…itnesses cover it)

The v1 Rust module was a duplicate harness: it resolved
src/v2/test/claim/manual/node_minimal_representation_test.dag and invoked 9
of its 10 'test fn' witnesses via the v1 interpreter. All 10 are
marker-discovered floor witnesses (src/v2 source-root pass; the dir is also a
live witness_discovery_scan_dirs entry), run 10/10 green via claim_batch, and
are discriminating: dropping NsfTypeAnnotation from
minimal_kind_owed_placement reds witness_partition_covers_superset_holds and
node_minimal_owed_bucket_count_holds while an unrelated witness stays green
(perturb commit reverted in-branch).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@gunbai-bot gunbai-bot Bot changed the title 5-test-migration — v1 burn-down: migrate v1 Rust test modules (~90 modules/~939 tests) into floor witnesses so v1 deletes unblock. SMALL PRs, one module/cluster each: re-express discriminating behavior as *_test.dag (marker-discovered, no hand-enrollment), perturb->red proof, delete the v1 module in 5-test-migration (3): delete v1 node_minimal_representation_test — floor witnesses already cover it Jul 2, 2026
@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review July 2, 2026 04:34
@briansrls
briansrls merged commit 91bedea into main Jul 2, 2026
0 of 2 checks passed
@briansrls
briansrls deleted the test-migration/node-minimal-representation branch July 2, 2026 04:47
briansrls pushed a commit that referenced this pull request Jul 2, 2026
…ion mod deletes (#6141)

PRs #6131/#6132/#6133/#6139 deleted 'mod <x>_test;' lines but left each line's
own #[cfg(test)] attribute, which now stacks onto the next declaration —
clippy::duplicated_attributes reds the v1 rust gate (fmt+clippy+nextest) on
main. Pure attribute cleanup, no behavior change.

Co-authored-by: Brian Searls <briansearls1@gmail.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant