Repository navigation
5-test-migration (2): delete dead v1 module r2_emit_add_named_test (0 tests, 0 callers) - #6132
Merged
Merged
Conversation
…est], 0 callers) The module has no #[test] functions and its three pub fns (assert_r2_emit_add_keystone / assert_keystone_green / assert_keystone_discriminates_on_mutation) have zero call sites anywhere in the tree — it never executes, so deleting it removes no coverage. The behavior it once harnessed lives in src/v2/test/claim/manual/rust_add_emit_translate_test.dag. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
briansrls
pushed a commit
that referenced
this pull request
Jul 2, 2026
…ion mod deletes (#6141) PRs #6131/#6132/#6133/#6139 deleted 'mod <x>_test;' lines but left each line's own #[cfg(test)] attribute, which now stacks onto the next declaration — clippy::duplicated_attributes reds the v1 rust gate (fmt+clippy+nextest) on main. Pure attribute cleanup, no behavior change. Co-authored-by: Brian Searls <briansearls1@gmail.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second PR of the 5-test-migration lane (v1 burn-down). Pure deletion, no
.dagedits.What
Delete
src/v1/tests/src/r2_emit_add_named_test.rs(114 LOC) and itsmodline inlib.rs.Why no witness migration is needed
The module is dead code: it contains zero
#[test]functions, and its threepub fns (assert_r2_emit_add_keystone,assert_keystone_green,assert_keystone_discriminates_on_mutation) have zero call sites anywhere in the tree (grep oversrc/— only themoddeclaration references it). It never executes undercargo testor anywhere else, so deleting it removes no coverage; there is nothing to migrate. The behavior it once harnessed (emitfn addkeystone + mutation discrimination) lives insrc/v2/test/claim/manual/rust_add_emit_translate_test.dag, whichtarget_model_runtime_import_repro.rsstill exercises (that module is a later, separate migration).Receipts
grep -rn "assert_r2_emit_add_keystone|assert_keystone_green|assert_keystone_discriminates_on_mutation" src/ --include=*.rs→ no hits outside the deleted file.cargo test -p v1-compiler-tests --no-runcompiles clean after the delete (exit 0).Per the lane brief: SMALL PRs; census §5B listed this module with "0 tests" already (docs/plans/seed-shrink-census.md — census otherwise stale vs live tree).
🤖 Generated with Claude Code