Skip to content

5-test-migration (8): cron_tag — witness authored, v1 module deleted - #6145

Merged
briansrls merged 4 commits into
mainfrom
test-migration/cron-tag
Jul 2, 2026
Merged

briansrls merged 4 commits into
mainfrom
test-migration/cron-tag

Conversation

@briansrls

@briansrls briansrls commented Jul 2, 2026 •

Copy link
Copy Markdown
Contributor

Eighth PR of the 5-test-migration lane. This slice closes only the cron_tag module; the lane node stays open.

What

  • New dsl/test/claim/cron_tag_witness_test.dag: marker-discovered test fn cron_tag_upsert_protocol_keystone_witness wrapping gunbc.tools.cron_tag.cron_tag_upsert_protocol_keystone_holds (previously unenrolled — cron_tag.dag is not a *_test.dag).
  • Delete src/v1/tests/src/cron_tag_test.rs (63 LOC, 2 tests), mod line removed together with its #[cfg(test)] attribute; inherited duplicate attributes deduped (trivial hotfix: remove 4 orphaned #[cfg(test)] attributes breaking clippy on main #6141 overlap on squash).

Coverage mapping

  • Test 1 (run keystone, expect true): identical witness fn, same interpreter path, now floor-enrolled.
  • Test 2 (in-memory mutation got == want → got != want must flip the witness false): re-expressed as this PR's committed perturb receipt rather than a permanent Rust test — the floor proves non-vacuity by the same mutation.

Receipts (green-by-execution + perturb→red, layer justified)

  1. Green: claim_batch --entry dsl/test/claim/cron_tag_witness_test.dag --functions cron_tag_upsert_protocol_keystone_witness → PASS.
  2. Discriminating: live realization is the .dag body (interpreter-evaluated, no native interceptor) — the exact mutation the v1 test used (got == want → got != want in dsl/gunbc/tools/cron_tag.dag) reds the floor witness (exit 1). Perturb commit reverted in-branch.
  3. cargo clippy -p v1-compiler-tests --all-targets -- -D warnings green at head.

🤖 Generated with Claude Code

Brian Searls and others added 4 commits July 2, 2026 06:41
cron_tag_upsert_protocol_keystone_holds is now floor-enrolled via the new
dsl/test/claim/cron_tag_witness_test.dag marker witness. The v1 module's
second test (in-memory got==want -> got!=want mutation check) is carried as
this PR's perturb->red receipt instead. mod line removed together with its
own #[cfg(test)] attribute; inherited duplicate attributes deduped (#6141
overlap).

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@gunbai-bot gunbai-bot Bot changed the title 5-test-migration — v1 burn-down: migrate v1 Rust test modules (~90 modules/~939 tests) into floor witnesses so v1 deletes unblock. SMALL PRs, one module/cluster each: re-express discriminating behavior as *_test.dag (marker-discovered, no hand-enrollment), perturb->red proof, delete the v1 module in 5-test-migration (8): cron_tag — witness authored, v1 module deleted Jul 2, 2026
@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review July 2, 2026 06:47
@briansrls
briansrls merged commit 47b6641 into main Jul 2, 2026
3 of 5 checks passed
@briansrls
briansrls deleted the test-migration/cron-tag branch July 2, 2026 15:11
briansrls added a commit that referenced this pull request Jul 3, 2026
Six rows were listing modules as full-debt after they had already
partially or fully migrated (per #6140/#6142/#6143/#6145/#6147/#6150/#6153):
render_repeat, cron_tag, money_carrier_cost_witness are fully deleted
from src/v1/tests/src/lib.rs (removed from table); fn_as_value_test,
witness_option_bridge_test, map_lookup_dual_dispatch_test,
coproduct_reflection_conformance_test shrunk to small pinned residuals
(LOC/test counts corrected against current main).

Co-authored-by: Brian Searls <briansrls@gmail.com>
Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant